System Icomparer shows up in the library

[ksobon]

I am not sure how this one found its way into the library:

[mjkkirschner]

• do you embed interop types into your dlls?
• do you reference this type at all?
• do you have any methods that accept or return an IComparer?

[ksobon]

Well yes, I do have a custom implementation of the Comparer class that looks like this:

        /// <summary>
        /// Comparer class that reverses the order of sorting.
        /// </summary>
        [IsVisibleInDynamoLibrary(false)]
        public class ReverseComparer : IComparer
        {
            /// <summary>
            /// 
            /// </summary>
            /// <param name="x"></param>
            /// <param name="y"></param>
            /// <returns></returns>
            public int Compare(object x, object y)
            {
                return new CaseInsensitiveComparer().Compare(y, x);
            }
        }

Again, it looks like the attribute [IsVisibleInDynamoLibrary(false)] is not working. This time it's a class not an enum.

[mjkkirschner]

@ksobon thanks
@Racel this looks like a pretty bad regression if true...

[mjkkirschner]

hmm @ksobon well, hmm, thats a little different - I totally get the behavior is changed...
But - your derived class is actually still hidden right? - but now the base class is showing ...

[ksobon]

Yes, that's correct. Perhaps the attribute was never meant to hide the base class?

[mjkkirschner]

rather, I think it was meant to hide the base class, but the regression might be very specific (why we missed it)

can you share your in development package.json file here and an image of your bin folder?

[mjkkirschner]

another thought - are you distributing dynamo core or dynamoServices with your packages? That will also cause this behavior. (if it's a different version of dynamo's assemblies) like you if distribute 1.3 core and run it on 2.0. (or building on the old dlls)

[ksobon]

So I was able to get it to hide itself when I changed the class to internal - obviously. I did try the [SupressImportIntoVM] attribute and that didn't work. I also tried putting [IsVisibleInDynamoLibrary(false)] attribute on both the class and the method inside of it since that was public as well, but that didn't work either.

Again, luckily I could actually make this one internal, so problem solved but it's something worth checking out.

/// <summary>
    /// Comparer class that reverses the order of sorting.
    /// </summary>
    internal class ReverseComparer : IComparer
    {
        /// <summary>
        /// 
        /// </summary>
        /// <param name="x"></param>
        /// <param name="y"></param>
        /// <returns></returns>
        public int Compare(object x, object y)
        {
            return new CaseInsensitiveComparer().Compare(y, x);
        }
    }

I don't distribute any of the mentioned libraries. I do reference them in for some of the UI work.

pkg.zip

[mjkkirschner]

@ksobon can you verify that your package (that you are testing) is built against the dynamo 2.x nugets and not the 1.3 ones?

[ksobon]

Yup.

[mjkkirschner]

tracked with:
https://jira.autodesk.com/browse/QNTM-4094

[aparajit-pratap]

@mjkkirschner I think it would be worth investigating the IsVisibleInDynamoLibrary and SuppressImport attributes to see if they're not broken. I think I saw a similar issue with these recently.

[johnpierson]

Tracked internally as QNTM-4094

[aparajit-pratap]

This is fixed in #9242. Closing. Let us know if you still see issues.