Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7525: DYN-7252: note edit textbox fix #15583

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 1, 2024

Purpose

Addressing issues with Edit Text window of the Note when zoomed out. Documented jira issue https://jira.autodesk.com/browse/DYN-7252?filter=-1

UI Changes

DynamoSandbox_zJEikJGy8M

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixing the caret positioning issue causing all the observed issues
  • restyling the window without overriding the textbox control template fixed the issue
  • also fixed the starting location of the window
  • the Accept button was not used (the text is being edited real-time), removing

Reviewers

@reddyashish

FYIs

@QilongTang

- fixing the caret positioning issue causing all the observed issues
- restyling the window without overriding the textbox control template fixed the issue
- also fixed the starting location of the window
- the Accept button was not used (the text is being edited real-time), removing
@github-actions github-actions bot changed the title Dyn 7525 note edit textbox fix DYN-: Dyn 7525 note edit textbox fix Nov 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7525

@dnenov dnenov changed the title DYN-: Dyn 7525 note edit textbox fix DYN-7525: note edit textbox fix Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@reddyashish
Copy link
Contributor

reddyashish commented Nov 1, 2024

@dnenov https://jira.autodesk.com/browse/DYN-7525 is different task, can you attach the correct one?

@QilongTang QilongTang added this to the 3.4 milestone Nov 1, 2024
@dnenov dnenov changed the title DYN-7525: note edit textbox fix DYN-7252: note edit textbox fix Nov 1, 2024
@github-actions github-actions bot changed the title DYN-7252: note edit textbox fix 7525: DYN-7252: note edit textbox fix Nov 1, 2024
@dnenov
Copy link
Collaborator Author

dnenov commented Nov 1, 2024

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7525

Thanks @reddyashish ! Manually typing it and got it wrong. :))

@reddyashish reddyashish changed the title 7525: DYN-7252: note edit textbox fix DYN-7252: note edit textbox fix Nov 4, 2024
@github-actions github-actions bot changed the title DYN-7252: note edit textbox fix 7525: DYN-7252: note edit textbox fix Nov 4, 2024
@reddyashish reddyashish merged commit e11ef19 into DynamoDS:master Nov 4, 2024
51 checks passed
reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request Nov 5, 2024
@reddyashish reddyashish mentioned this pull request Nov 5, 2024
9 tasks
@dnenov dnenov mentioned this pull request Nov 6, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants