DYN-7523: editwindow fix #15615
Merged
DYN-7523: editwindow fix #15615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed anonymous subscription - immediately unsubscribe after calling the event to prevent leaking - removed redundant test code
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7523
reddyashish
reviewed
Nov 6, 2024
| } | ||
|
|
||
| // Centralize the window correctly after it is rendered | ||
| private void OnContentRendered(object sender, EventArgs e) |
There was a problem hiding this comment.
This is subscribed in the editwindow fn but when is it being called?
There was a problem hiding this comment.
This one is the very last event to be called when a Window is placed. It is called even after Loaded. I use it to re-centralize the window as there is something else affecting it externally, which I cannot catch.
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
approved these changes
Nov 7, 2024
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit 7f40772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a follow up on #15583 which was recently merged. I am addressing potential leak introduced in the previous PR by introducing anonymous event subscription. The fix is mainly making these explicit, and unsubscribing immediately after the first call. This should ensure no unsubscribed events remain after the window is closed.
Also, removed a small bit of unnecessary test code that was accidentally left over.
Tagging this PR with the old Jira issue.
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@zeusongit
@QilongTang
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of