DYN-7343: Pm search compatibility filters update #15603
Conversation
- compatible and incompatible filters should be mutually exclusive - small ui fix with alternating row background color for the compatibility matrix
- aligning to website design, we convert any wildcard symbol to lowercase 'x' - only do it on the UI, not touching the actual string value (using converter) - alternating rows background color fix
dnenov
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7343
UI Smoke TestsTest: success. 11 passed, 0 failed. |
| @@ -6480,7 +6480,7 @@ | |||
| <Setter Property="BorderBrush" Value="{StaticResource DarkMidGreyBrush}" /> | |||
| <Setter Property="ColumnWidth" Value="Auto" /> | |||
| <Setter Property="GridLinesVisibility" Value="Vertical" /> | |||
| <Setter Property="VerticalGridLinesBrush" Value="{StaticResource DarkMidGreyBrush}" /> | |||
| <Setter Property="VerticalGridLinesBrush" Value="#646464" /> | |||
There was a problem hiding this comment.
Hmm this looks like backward to me?
There was a problem hiding this comment.
I updated this to match the design we have on Figma. It meant that I needed to add a new color to the swatch of colors we used so far. https://www.figma.com/design/MJh76m7bbafE3sjwLUTZhZ/Dynamo-package-manager-update?node-id=2397-31482&node-type=canvas&t=OCvkjGxUxDFeO1qW-0
I pushed a new commit making it a resource, which I should have done to begin with, apologies @QilongTang .
|
Jenkins reports 1 test timing out, the test passes locally .. I don't see how it is connected with any of these changes.
|
Merging since the test in unrelated. And yes, I have seen that fail for other PRs too, is this related to this PR #15583? fyi @reddyashish |
|
The tests passed on that PR though. I will check that test again with those changes |
Purpose
A few minor issues/alignments to push before 3.4.
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
CompatibleandIncompatiblefilters are now exclusive @QilongTang @hwahlstrom*toxconversion for the UIcompatibility matrixReviewers
@zeusongit
@QilongTang
FYIs
@reddyashish