Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-7201 Fix info bubble updates #15355

Merged
merged 2 commits into from
Jul 1, 2024
Merged

DYN-7201 Fix info bubble updates #15355

merged 2 commits into from
Jul 1, 2024

Conversation

pinzart90
Copy link
Contributor

Issue:
Info bubbles (as opposed to warnings or errors) do not show up on nodes after graph execution
image

Purpose

In this PR I updated the node GUIDS that are passed to the UpdateNodeInfoBubbleContent method

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix regression where information bubbles did not show on nodes after graph execution

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@pinzart90 pinzart90 requested review from QilongTang and Amoursol June 28, 2024 02:04
@QilongTang QilongTang added this to the 3.2.2 milestone Jun 28, 2024
@QilongTang QilongTang mentioned this pull request Jun 28, 2024
Merged
9 tasks
@twastvedt twastvedt changed the title fix info bubble updates DYN-7201 Fix info bubble updates Jul 1, 2024
github-actions[bot]
github-actions bot reviewed Jul 1, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7201

@pinzart90 pinzart90 merged commit cb6c6ae into master Jul 1, 2024
25 of 27 checks passed
@pinzart90 pinzart90 deleted the fix_info_bubbles branch July 1, 2024 15:40
QilongTang pushed a commit that referenced this pull request Jul 2, 2024
@pinzart90 @QilongTang
DYN-7201 Fix info bubble updates (#15355)
ab21da7
@QilongTang QilongTang mentioned this pull request Jul 2, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Jul 2, 2024
@QilongTang @pinzart90 @RobertGlobant20
DYN-7203 [Cherry-pick] #15355 and #15361 (#15368)
0404772 
Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: Roberto T <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@aparajit-pratap aparajit-pratap aparajit-pratap approved these changes

@QilongTang QilongTang Awaiting requested review from QilongTang

@Amoursol Amoursol Awaiting requested review from Amoursol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pinzart90 @aparajit-pratap @QilongTang