Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7200 use hardcoded string for type name instead of typeof operator #15358

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jun 28, 2024

Purpose

This fixes a potential issue where an older version of DynamoCore not containing the PanelSurface type is run with Player pointing to a new version of DynamoCore that contains that type. To avoid potential type load exceptions in this scenario, this PR avoids the use of typeof operator and uses a hardcoded string instead for the type.

❕ This needs to be cherry-picked into 3.2.2.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang modified the milestones: 3.3, 3.2.2 Jun 28, 2024
@QilongTang
Copy link
Contributor

Morpheus team will make the branch ready shortly. Next week, we will contact DynamoRevit team to see if they are willing to adopt this fix as well as #15355 in 3.2.2. Stay tuned and thank you for proposing the fix 🚀

@pinzart90 pinzart90 merged commit 310d820 into DynamoDS:master Jul 1, 2024
26 of 32 checks passed
@aparajit-pratap aparajit-pratap deleted the fixtype branch July 1, 2024 13:43
@twastvedt twastvedt changed the title use hardcoded string for type name instead of typeof operator DYN-7200 use hardcoded string for type name instead of typeof operator Jul 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7200

@QilongTang QilongTang modified the milestones: 3.2.2, 3.3 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants