DYN-7139 WebView2 Crash when Opening Dialog #15361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebView2 was crashing when opening the OpenFile Dialog or the OpenTemplate Dialog, it was due that we were not using an async method for opening the file/template. Then I added an async method and will be called by the HomeApp component.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7139
|
GIF showing that now WebView2 doesn't crash. |
QilongTang
reviewed
Jun 28, 2024
I was missing to implement the same fix for the next functionalities that also open a File OpenDialog from WebView2: - Open a Template (shortcut Ctrl + T) - Open (shortcut Ctrl + O) Finally I modified the functionality for using Commands instead of calling the method directly.
pinzart90
reviewed
Jun 30, 2024
Updating call to use a Dispatcher
|
Hi @RobertGlobant20 Notice the first PR check failed? Because you have added new public functions, you need to modify the file to add them to pass API break analysis |
Updating the public API so we won't get a API Break check.
Updating the public API so we won't get a API Break check.
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
reviewed
Jul 1, 2024
| @@ -2067,6 +2067,10 @@ Dynamo.ViewModels.DynamoViewModel.ShowOpenDialogAndOpenResultCommand.get -> Dyna | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenDialogAndOpenResultCommand.set -> void | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenTemplateDialogCommand.get -> Dynamo.UI.Commands.DelegateCommand | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenTemplateDialogCommand.set -> void | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenDialogAndOpenResultAsyncCommand.get -> Dynamo.UI.Commands.DelegateCommand | |||
Removing extra space
QilongTang
approved these changes
Jul 2, 2024
QilongTang
pushed a commit
that referenced
this pull request
Jul 2, 2024
9 tasks
QilongTang
added a commit
that referenced
this pull request
Jul 2, 2024
Co-authored-by: pinzart90 <[email protected]> Co-authored-by: Roberto T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
WebView2 was crashing when opening the OpenFile Dialog or the OpenTemplate Dialog, it was due that we were not using an async method for opening the file/template. Then I added an async method and will be called by the HomeApp component.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
WebView2 was crashing when opening the OpenFile Dialog
Reviewers
@QilongTang
FYIs
@reddyashish