DYN-6554 Revert UI Blocking Function calls #14766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
I dont understand.. PR check on master-5 finished without any regression but indicate fail state so the PR check here never finished. See https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/12587/ At the same time, self serve on master-15 passed at https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1355/ Merging.. |
QilongTang
added a commit
that referenced
this pull request
Dec 15, 2023
9 tasks
QilongTang
added a commit
that referenced
this pull request
Dec 15, 2023
QilongTang
added a commit
that referenced
this pull request
Feb 29, 2024
QilongTang
added a commit
that referenced
this pull request
Mar 1, 2024
* Re-work watch node display logic (#14841) * improvements (#14497) * [DYN-6455] Add warning text to selection node's initial warning (#14833) * Fix PostDiff job * Update Selection.cs * made the warning persistent and then add removal code * [DYN-6585] Fix Export workspace as Image option from Menu Item (#14809) * Fix PostDiff job * Update DynamoView.xaml * Revert UI Blocking Function calls (#14766) * [DYN-6354] Fix incorrect confidence score display in ML suggestions (#14829) * Fix PostDiff job * Update NodeAutoCompleteSearchViewModel.cs * Update * DYN-5745 re enable copy/paste capabilities for library searchBar (#14492) * feat(library): keydown events binding and copy/paste for clipboard management * refactor(library): OnPasteFromClipboard function for clipboard management including comments * DYN-6364 Skip Lucene indexing process in UIless mode (#14523) * skip Lucene indexing process in UIless mode * Update comments --------- Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Enzo Batista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Per https://jira.autodesk.com/browse/DYN-6554, This PR reverts a part of the changes from #13973 because it causes some undesired UI side effects to the preview bubble when launching the preferences panel and package manager. Morpheus team decided to keep this function call only for guided tour and borrow the overlay mechanism from the guided tour to apply to Preferences Panel and PM open by another PR.
Before:
After:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@RobertGlobant20
FYIs
@DynamoDS/dynamo