DYN-6364 Skip Lucene indexing process in UIless mode #14523
Conversation
|
Did you get a chance to test this in Revit? |
|
|
| @@ -60,6 +60,8 @@ internal LuceneSearchUtility(DynamoModel model) | |||
| /// </summary> | |||
| internal void InitializeLuceneConfig(string dirName, LuceneStorage storageType = LuceneStorage.FILE_SYSTEM) | |||
| { | |||
| if (DynamoModel.IsHeadless) return; | |||
There was a problem hiding this comment.
So this should be set from all CLIs and D4R ( if not taken care of in core ) when the model starts without UI right ?
Also we should check with D4C3D.
The bug is not reproducible in Revit because Revit Dynamo Player always try to reuse the same DynamoModel when launching Dynamo, in that case, it will be the same indexwriter so search works there. In Alias case, the Alias Dynamo Player and Dynamo are launched as two different processes, |
|
@reddyashish Also I think this PR will replace #14440 so we do not have to touch the startConfig, what do you think? |
|
yeah wouldn't need it. Closed that PR |
| @@ -60,6 +60,8 @@ internal LuceneSearchUtility(DynamoModel model) | |||
| /// </summary> | |||
| internal void InitializeLuceneConfig(string dirName, LuceneStorage storageType = LuceneStorage.FILE_SYSTEM) | |||
| { | |||
| if (DynamoModel.IsHeadless) return; | |||
There was a problem hiding this comment.
perhaps you should mention this change in the comments for IsHeadLess mode, or do you not intend to port this change to master?
There was a problem hiding this comment.
I can update comments there
|
The reported regression |
* skip Lucene indexing process in UIless mode * Update comments
* skip Lucene indexing process in UIless mode * Update comments
* skip Lucene indexing process in UIless mode * Update comments Co-authored-by: Aaron (Qilong) <[email protected]>
* Re-work watch node display logic (#14841) * improvements (#14497) * [DYN-6455] Add warning text to selection node's initial warning (#14833) * Fix PostDiff job * Update Selection.cs * made the warning persistent and then add removal code * [DYN-6585] Fix Export workspace as Image option from Menu Item (#14809) * Fix PostDiff job * Update DynamoView.xaml * Revert UI Blocking Function calls (#14766) * [DYN-6354] Fix incorrect confidence score display in ML suggestions (#14829) * Fix PostDiff job * Update NodeAutoCompleteSearchViewModel.cs * Update * DYN-5745 re enable copy/paste capabilities for library searchBar (#14492) * feat(library): keydown events binding and copy/paste for clipboard management * refactor(library): OnPasteFromClipboard function for clipboard management including comments * DYN-6364 Skip Lucene indexing process in UIless mode (#14523) * skip Lucene indexing process in UIless mode * Update comments --------- Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Enzo Batista <[email protected]>
* skip Lucene indexing process in UIless mode * Update comments
Purpose
Skip the node indexing process when DynamoModel launches in UIless mode (usually happens in Player context), so there will be no index files created or locked. I believe this one line fix will work because Lucene Initialization, e.g. indexwriter creation is part of DynamoModel initialization. As a result, as long as indexwriter is not created, any indexing process later will not work and will not create any index and lock them or overwrite the existing index.
Notice this is a quick fix for 2.19.4, for future 2.19.x hotfixes, we may want to adopt the Lucene index improvements from master branch.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Dynamo and Alias Dynamo Player can be launched at the same time
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of