DYN-5745 re enable copy/paste capabilities for library searchBar #14492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Oct 18, 2023
| @@ -32,6 +32,29 @@ namespace Dynamo.LibraryViewExtensionWebView2 | |||
| { | |||
| [PermissionSet(SecurityAction.Demand, Name = "FullTrust")] | |||
| [ComVisibleAttribute(true)] | |||
|
|
|||
| public class ScriptObject | |||
There was a problem hiding this comment.
comments for public class and methods please, also please confirm if they need to be public or could be internal
There was a problem hiding this comment.
They have to be public as we access them through webview.hostObjects.scriptObject otherwise they wouldn't be usable from the Library component.
QilongTang
reviewed
Oct 18, 2023
QilongTang
reviewed
Oct 18, 2023
…ment including comments
QilongTang
approved these changes
Oct 19, 2023
QilongTang
added a commit
that referenced
this pull request
Mar 1, 2024
* Re-work watch node display logic (#14841) * improvements (#14497) * [DYN-6455] Add warning text to selection node's initial warning (#14833) * Fix PostDiff job * Update Selection.cs * made the warning persistent and then add removal code * [DYN-6585] Fix Export workspace as Image option from Menu Item (#14809) * Fix PostDiff job * Update DynamoView.xaml * Revert UI Blocking Function calls (#14766) * [DYN-6354] Fix incorrect confidence score display in ML suggestions (#14829) * Fix PostDiff job * Update NodeAutoCompleteSearchViewModel.cs * Update * DYN-5745 re enable copy/paste capabilities for library searchBar (#14492) * feat(library): keydown events binding and copy/paste for clipboard management * refactor(library): OnPasteFromClipboard function for clipboard management including comments * DYN-6364 Skip Lucene indexing process in UIless mode (#14523) * skip Lucene indexing process in UIless mode * Update comments --------- Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Enzo Batista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ref.: DYN-5745
This PR includes a fix that allow us to manage the clipboard Ctrl + C and Ctrl + V on library search.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
First I've added a keydown events binding mechanism for matching .net events to javascript ones using dispatchEvent(). Then I created the methods for clipboard management in Dynamo, so we can copy and paste between library search and Dynamo.
Reviewers
@QilongTang
@RobertGlobant20
FYIs
@avidit