DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. #14637

mjkkirschner · 2023-11-22T00:39:00Z

Purpose

when feature flags does not retrieve data, don't log for every single flag check - this leads to extremely poor performance as WPF tries to update the console window. The console is also guarded by a lock.
Modify the CLIWrapper class method GetData which reads from standard out of the wrapped processes - so that this method is async, and will timeout after a client controllable timeout.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

…rapperloop

mjkkirschner · 2023-11-22T15:28:13Z

@sm6srw I'd like to add automated tests to this, but we can get it in sooner and followup so civil can consume it if you prefer.

src/DynamoUtilities/Md2Html.cs

sm6srw · 2023-11-22T16:27:38Z

I don't think we need it asap for civil so adding tests is ok.

src/DynamoUtilities/DynamoFeatureFlagsManager.cs

src/DynamoUtilities/Md2Html.cs

src/DynamoUtilities/DynamoFeatureFlagsManager.cs

pinzart90 · 2023-11-22T18:00:48Z

src/DynamoUtilities/DynamoFeatureFlagsManager.cs

@@ -87,12 +99,21 @@ internal T CheckFeatureFlag<T>(string featureFlagKey, T defaultval)
                return defaultval;
            }
            // if we have not retrieved flags from the cli return empty
-            // and log.
+            // and log once,

            if(AllFlagsCache == null)


is this thread safe ?

src/DynamoUtilities/Md2Html.cs

mjkkirschner · 2023-11-22T22:17:34Z

@pinzart90 @sm6srw @aparajit-pratap please take another look:

discussed with Tibi a bit, and I removed even more logging from FF for now.
filed a followup to improve our logging system so it can't overwhelm the UI. Added TODOs inline for this task.
added tests and increased the timeouts.

src/DynamoUtilities/Md2Html.cs

commit f5d5563 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 12:12:19 2023 +0000 dispose methods null checks - trying to prevent null exceptions in case resources have been cleared before dispose event has been called commit e43ad53 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 11:05:20 2023 +0000 remove begin invoke from mainFrame_Navigated - this was done to try and fix a failing test but it should not be needed commit 42bf04c Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 21:04:19 2023 +0000 null check to mainFrame_Navigated - added a null check commit 9dde030 Merge: a77a11a 3f765b5 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 18:07:39 2023 +0000 Merge branch 'pm-publishpackage-cherrypick-resources' into pm-publishpackage-cherrypick-mypackage commit a77a11a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:47:17 2023 +0000 main changes - this cherry-pick contains all main changes minus resources and tests. - will need to merge resources to work correctly - if this breaks the test run, we will need to further split it up, or introduce the changes one by one somehow commit 3f765b5 Merge: 95d502a 36fb8d3 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:11 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-cherrypick-resources commit 95d502a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:02 2023 +0000 resource cherry-pick - picked up all resource changes commit 36fb8d3 Author: Jorgen Dahl <[email protected]> Date: Mon Nov 27 11:51:35 2023 -0500 Test net8 (DynamoDS#14635) * Test net8 * Also add DotNet to the build properties * Update CS_SDK.props * Update CS_SDK.props * update * update * update * Go back to net6 --------- Co-authored-by: pinzart <[email protected]> commit cbba6d0 Author: Michael Kirschner <[email protected]> Date: Mon Nov 27 11:26:04 2023 -0500 DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. (DynamoDS#14637) * fix for null data being shown over and over * fix issues with cli wrapper get data * revert * add test * review comments add tests * comments * review comments commit c5df6f9 Author: Ashish Aggarwal <[email protected]> Date: Mon Nov 27 11:22:32 2023 -0500 Replace Application.Current with HostAnalyticsInfo.HostName check (DynamoDS#14574) * Fix PostDiff job * replace application.current * tests * refactor after Bogdans PR --------- Co-authored-by: Aaron (Qilong) <[email protected]> commit 11b1f7c Author: jesusalvino <[email protected]> Date: Mon Nov 27 08:55:32 2023 -0500 DYN-6313 Add ML Node AutoComplete TOU (DynamoDS#14625) * Updating the Agreement and Term of Use * Adding the MLNodeAuntocomplete rtf file * Persists the AgreeToMLAutocompleteTOU as preference settings * rename property * resources and control names * Clean up * Update * update --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> commit 3e97cbd Author: Aabishkar KC <[email protected]> Date: Wed Nov 22 12:56:04 2023 -0500 Update smoke tests workflow (DynamoDS#14638)

* colors in config.js - now all colors are controlled by the COLORS object in confing.js * folder structure - correctly creates minimum depth folder structure for the files added * getting somewhere with browser - updated browser to only show root items * added pages - added pages for the wizard-like experience when publishing a package * connected packagecontents and rootcontents * misc changes * tree visual update fix - using Dispatcher fixes the async tree creation * wip * tests added - tests added to assert correct functionality of collecting files and folders * visual style tweaks - updated files and folders icons - now only allows LibraryNode checkboxes for Assembly dll files * previewbuild started - started the structure for preview build * testing preview functionality - added tests for the core methods of PreviewPackageBuild * delete folders working - changed `RemoveItem` method to account for folder items being removed - fixed a bug where removing an Assembly file would generate an error. Assembly files can also be added to 'additional items' * item selection and deletion - UI added to allow users to add/remove items from current Package selection * remove inactive selection border background - ui tweaks * preview contents, bugfix - preview contents now correctly display based on user choice (retain folder or not) - fixed a bug where CustomDefinitions would read as root item - Pages are disabled when not displayed, in order to stop handling of tasks that affect other Pages * browser sorting - now sorts browser alphabetically - fixed disabled behavior * assemblies show as files - assemblies now will show up with their file path, but still get picked up from their assembly resource on disk * customnode preview item added - we need the ability to display custom nodes as file with file paths during package creation. CustomDefinition does not have the attributes to address that, so we are adding a new 'preview' item type to server the purpose * delete item tests added - added tests for delete item - fixed an issue where removing all items would not result in cleaning the RootContent items - added detailed description for the customTreeView_SelectedItemChanged method * consistent select all behavior - fixed checkbox behavior to be consistent when interacting with the rest of the controls * clear data and ui - clearing data and ui after publishing - clearing data and ui with Cancel button * main flow finished - finished the main flow between the pages * retain folder structure - publish local retaining folder structure * navigation way, cancel prompts - now warns the user of losing changes if using cancel or navigating away * clear custom filepaths when clearing package controls - also clear custom definition filepaths * removing items more tests added - added more tests around removing items * tests preview items structure to created package - tests added to assert preview package structure is identical to the created package structure * test remove multiple - added test to assert correct removal of multiple root items - publish package clears on window close without prompt - added ellipsis for package name - center message prompts to main view * fixed custombrowsercontrol visuals - multiple ui fixes to the custom browser control * ui styling fixes - rework on the custom browser user control to correctly display dotted lines - no longer treats every assembly as NodeLibrary * rework of retain folder structure - change the logic of how to collect files under multiple root folders when using retain folder structure - keywords fix, added tests * minor refactor * resources * hover and tooltips - adding hover states - adding tooltips - removing old resources * resources * adding packagebuilder tests - adding tests for BuildRetainDirectory * submit package retaining folder structure - created the second path to submitting packages online retaining folder structure - tests added * publish retain folder done - finished workflow for publishing package reatining folder - changed UI finish screen to work differently depending on which workflow was taken - publish locally or online - tests added * exclude unmanaged dlls - unmanaged dll files cannot be Node Library - fixed Node Library preview * description removed, name validation adorner added - removed description from package validation rules - added name error validation and adorner * tooltips - fixed tooltips and styles * remove PublishPackageReadyToPublishPage - PublishPackageReadyToPublishPage was not used, removed * keywords tags - added keywords tags - TODO: should we replace Kewords with KewordsCollection when submitting a package? * host control updated - updated the host control visuals - tooltips update * build version error message - added build version error message * rework markdown path locator - added new control when no markdown path is selected * numeric up/down fix and tests - added tests for numeric up/down - space is now handled and should not be allowed - new validation rule for package Name field * starting space rule - no longer able to start with a space for all input fields - allows user to skip adding minor and build values will be replaced with default ones * new validation rules - updated validation rules as per Figma * remove empty tooltips - remove unnecessary tooltip to the content presenter - added 1 missing tooltip to line items * fix * comment to PublishRetainFolderStructure - added a detailed comment describing the new PublishRetainFolderStructure method * remove duplicate icon.png from test folders - removed duplicate icon.png files / replaced with empty text files instead - updated tests that were failing since last changes * comments to public properties added * restored deleted namespaces - not sure how the namespaces got wiped with the previous commit * remove unused icons * failing tests fix - the tests were failing because another test folder was starting with a preceding alphabet letter * remove commented out code * update mypackages ui and functionality - starting the work around MyPackages tab * replaced bullet menu icon - now uses vector path rather than png icon (scalable) * refresh datacontext on change - now correctly refreshes the PublishPackageViewModel datacontext when publishing new package version * memory leak * PublishNewVersionCommand inside PackageManagerViewModel - the design dictates that we trigger a `publish version` command from inside a packageManagerSearchElementViewModel, which is separated from the PackageViewModel that has all the necessary methods for that - we are using the PackageManagerViewModel as the highest order VM that to create a bridge between the search element and the installed package * wire the command * unsubscribe from event handlers - unsunbscribing from a few unattended event handlers - removed EntryDictionary, it wasn't used anywhere but was taking resources - unsubsribing from ele.RequestShowFileDialog -= OnRequestShowFileDialog; for each searchelementVM this time! * clear breadcrumbs * publish tab no memory leak - publish tab is not leaking * BrowserItemViewModel dispose - implement dispose method inside the BrowserItemViewModel to unsubscribe from the ItemsOnCollectionChanged event * disabled PublishingACustomNodeSetsPackageInfoCorrectly_ test - disabled this test for the moment, it contaminates the packages folder by creating a package and leading to numerous failure tests consequently * fixed minor bugs - fixed a bug where the install to folder would not show the required dialog - fixed a bug where after locking the name for edit (after submitting a new package version) clearing the results would not remove the block from typing the name * Squashed commit of the following: commit f5d5563 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 12:12:19 2023 +0000 dispose methods null checks - trying to prevent null exceptions in case resources have been cleared before dispose event has been called commit e43ad53 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 11:05:20 2023 +0000 remove begin invoke from mainFrame_Navigated - this was done to try and fix a failing test but it should not be needed commit 42bf04c Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 21:04:19 2023 +0000 null check to mainFrame_Navigated - added a null check commit 9dde030 Merge: a77a11a 3f765b5 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 18:07:39 2023 +0000 Merge branch 'pm-publishpackage-cherrypick-resources' into pm-publishpackage-cherrypick-mypackage commit a77a11a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:47:17 2023 +0000 main changes - this cherry-pick contains all main changes minus resources and tests. - will need to merge resources to work correctly - if this breaks the test run, we will need to further split it up, or introduce the changes one by one somehow commit 3f765b5 Merge: 95d502a 36fb8d3 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:11 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-cherrypick-resources commit 95d502a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:02 2023 +0000 resource cherry-pick - picked up all resource changes commit 36fb8d3 Author: Jorgen Dahl <[email protected]> Date: Mon Nov 27 11:51:35 2023 -0500 Test net8 (#14635) * Test net8 * Also add DotNet to the build properties * Update CS_SDK.props * Update CS_SDK.props * update * update * update * Go back to net6 --------- Co-authored-by: pinzart <[email protected]> commit cbba6d0 Author: Michael Kirschner <[email protected]> Date: Mon Nov 27 11:26:04 2023 -0500 DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. (#14637) * fix for null data being shown over and over * fix issues with cli wrapper get data * revert * add test * review comments add tests * comments * review comments commit c5df6f9 Author: Ashish Aggarwal <[email protected]> Date: Mon Nov 27 11:22:32 2023 -0500 Replace Application.Current with HostAnalyticsInfo.HostName check (#14574) * Fix PostDiff job * replace application.current * tests * refactor after Bogdans PR --------- Co-authored-by: Aaron (Qilong) <[email protected]> commit 11b1f7c Author: jesusalvino <[email protected]> Date: Mon Nov 27 08:55:32 2023 -0500 DYN-6313 Add ML Node AutoComplete TOU (#14625) * Updating the Agreement and Term of Use * Adding the MLNodeAuntocomplete rtf file * Persists the AgreeToMLAutocompleteTOU as preference settings * rename property * resources and control names * Clean up * Update * update --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> commit 3e97cbd Author: Aabishkar KC <[email protected]> Date: Wed Nov 22 12:56:04 2023 -0500 Update smoke tests workflow (#14638) * update selected known host value on clear - fixed a small issue where the selected known hosts were not being cleared on reset * changes to publish package name validation - moved small fixes to publish package name validation to this branch * font size alignment * font size change * font weight change * remove redundant test files * added missing resource * rename ThisDataContextChanged to PackageManagerPublishControl_DataContextChanged --------- Co-authored-by: Craig Long <[email protected]>

commit ca1b5eb Merge: 50c0844 c640470 Author: Deyan Nenov <[email protected]> Date: Mon Dec 4 18:38:22 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-mypackages-update commit 50c0844 Author: Deyan Nenov <[email protected]> Date: Mon Dec 4 11:05:09 2023 +0000 rename ThisDataContextChanged to PackageManagerPublishControl_DataContextChanged commit bd0e65a Author: Deyan Nenov <[email protected]> Date: Fri Dec 1 17:56:10 2023 +0000 added missing resource commit 1c0e12f Author: Deyan Nenov <[email protected]> Date: Fri Dec 1 15:23:59 2023 +0000 remove redundant test files commit b8f8b05 Merge: c57133c b9ebaca Author: Deyan Nenov <[email protected]> Date: Fri Dec 1 15:18:03 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-mypackages-update commit c57133c Author: Deyan Nenov <[email protected]> Date: Thu Nov 30 20:13:16 2023 +0000 font weight change commit 4767c6f Author: Deyan Nenov <[email protected]> Date: Thu Nov 30 19:18:56 2023 +0000 font size change commit e0a1f06 Author: Deyan Nenov <[email protected]> Date: Thu Nov 30 16:51:45 2023 +0000 font size alignment commit 1ec3d95 Merge: d3a4448 45038c5 Author: Deyan Nenov <[email protected]> Date: Thu Nov 30 16:24:11 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-mypackages-update commit d3a4448 Merge: 7cc915a 1649d66 Author: Deyan Nenov <[email protected]> Date: Wed Nov 29 18:44:39 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-mypackages-update commit 7cc915a Author: Deyan Nenov <[email protected]> Date: Wed Nov 29 15:35:38 2023 +0000 changes to publish package name validation - moved small fixes to publish package name validation to this branch commit 64058c6 Author: Deyan Nenov <[email protected]> Date: Wed Nov 29 15:05:53 2023 +0000 update selected known host value on clear - fixed a small issue where the selected known hosts were not being cleared on reset commit 6d8c7ea Author: Deyan Nenov <[email protected]> Date: Wed Nov 29 13:48:16 2023 +0000 Squashed commit of the following: commit f5d5563 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 12:12:19 2023 +0000 dispose methods null checks - trying to prevent null exceptions in case resources have been cleared before dispose event has been called commit e43ad53 Author: Deyan Nenov <[email protected]> Date: Tue Nov 28 11:05:20 2023 +0000 remove begin invoke from mainFrame_Navigated - this was done to try and fix a failing test but it should not be needed commit 42bf04c Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 21:04:19 2023 +0000 null check to mainFrame_Navigated - added a null check commit 9dde030 Merge: a77a11a 3f765b5 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 18:07:39 2023 +0000 Merge branch 'pm-publishpackage-cherrypick-resources' into pm-publishpackage-cherrypick-mypackage commit a77a11a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:47:17 2023 +0000 main changes - this cherry-pick contains all main changes minus resources and tests. - will need to merge resources to work correctly - if this breaks the test run, we will need to further split it up, or introduce the changes one by one somehow commit 3f765b5 Merge: 95d502a 36fb8d3 Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:11 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-cherrypick-resources commit 95d502a Author: Deyan Nenov <[email protected]> Date: Mon Nov 27 17:38:02 2023 +0000 resource cherry-pick - picked up all resource changes commit 36fb8d3 Author: Jorgen Dahl <[email protected]> Date: Mon Nov 27 11:51:35 2023 -0500 Test net8 (DynamoDS#14635) * Test net8 * Also add DotNet to the build properties * Update CS_SDK.props * Update CS_SDK.props * update * update * update * Go back to net6 --------- Co-authored-by: pinzart <[email protected]> commit cbba6d0 Author: Michael Kirschner <[email protected]> Date: Mon Nov 27 11:26:04 2023 -0500 DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. (DynamoDS#14637) * fix for null data being shown over and over * fix issues with cli wrapper get data * revert * add test * review comments add tests * comments * review comments commit c5df6f9 Author: Ashish Aggarwal <[email protected]> Date: Mon Nov 27 11:22:32 2023 -0500 Replace Application.Current with HostAnalyticsInfo.HostName check (DynamoDS#14574) * Fix PostDiff job * replace application.current * tests * refactor after Bogdans PR --------- Co-authored-by: Aaron (Qilong) <[email protected]> commit 11b1f7c Author: jesusalvino <[email protected]> Date: Mon Nov 27 08:55:32 2023 -0500 DYN-6313 Add ML Node AutoComplete TOU (DynamoDS#14625) * Updating the Agreement and Term of Use * Adding the MLNodeAuntocomplete rtf file * Persists the AgreeToMLAutocompleteTOU as preference settings * rename property * resources and control names * Clean up * Update * update --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> commit 3e97cbd Author: Aabishkar KC <[email protected]> Date: Wed Nov 22 12:56:04 2023 -0500 Update smoke tests workflow (DynamoDS#14638) commit 79cfc13 Author: Deyan Nenov <[email protected]> Date: Fri Nov 24 16:33:36 2023 +0000 fixed minor bugs - fixed a bug where the install to folder would not show the required dialog - fixed a bug where after locking the name for edit (after submitting a new package version) clearing the results would not remove the block from typing the name commit 6e4d890 Merge: 17df8b6 28130fb Author: Deyan Nenov <[email protected]> Date: Fri Nov 24 15:54:05 2023 +0000 Merge branch 'pm-publishpackage-packagecontents-revert' into pm-mypackages-update commit 28130fb Author: Deyan Nenov <[email protected]> Date: Fri Nov 24 15:45:35 2023 +0000 disabled PublishingACustomNodeSetsPackageInfoCorrectly_ test - disabled this test for the moment, it contaminates the packages folder by creating a package and leading to numerous failure tests consequently commit 85994db Merge: 8096f65 b0b86ae Author: Deyan Nenov <[email protected]> Date: Wed Nov 22 17:37:31 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents-revert commit 8096f65 Author: Deyan Nenov <[email protected]> Date: Wed Nov 22 17:37:16 2023 +0000 BrowserItemViewModel dispose - implement dispose method inside the BrowserItemViewModel to unsubscribe from the ItemsOnCollectionChanged event commit b822e2c Author: Deyan Nenov <[email protected]> Date: Wed Nov 22 13:02:50 2023 +0000 publish tab no memory leak - publish tab is not leaking commit 17df8b6 Author: Deyan Nenov <[email protected]> Date: Wed Nov 22 12:04:54 2023 +0000 clear breadcrumbs commit 7ce3c9e Author: Deyan Nenov <[email protected]> Date: Tue Nov 21 23:25:42 2023 +0000 unsubscribe from event handlers - unsunbscribing from a few unattended event handlers - removed EntryDictionary, it wasn't used anywhere but was taking resources - unsubsribing from ele.RequestShowFileDialog -= OnRequestShowFileDialog; for each searchelementVM this time! commit 3deae08 Author: Deyan Nenov <[email protected]> Date: Tue Nov 21 12:49:34 2023 +0000 wire the command commit f2ef48f Author: Deyan Nenov <[email protected]> Date: Tue Nov 21 12:40:38 2023 +0000 PublishNewVersionCommand inside PackageManagerViewModel - the design dictates that we trigger a `publish version` command from inside a packageManagerSearchElementViewModel, which is separated from the PackageViewModel that has all the necessary methods for that - we are using the PackageManagerViewModel as the highest order VM that to create a bridge between the search element and the installed package commit 379edac Merge: 5706467 2676995 Author: Deyan Nenov <[email protected]> Date: Mon Nov 20 20:03:33 2023 +0000 Merge branch 'pm-publishpackage-packagecontents-ml' into pm-publishpackage-packagecontents-revert commit 2676995 Author: Deyan Nenov <[email protected]> Date: Mon Nov 20 20:03:23 2023 +0000 memory leak commit 5706467 Merge: 69e9fe9 b658456 Author: Deyan Nenov <[email protected]> Date: Mon Nov 20 19:28:52 2023 +0000 Merge branch 'pm-publishpackage-packagecontents-ml' into pm-publishpackage-packagecontents-revert commit 72954ca Author: Deyan Nenov <[email protected]> Date: Mon Nov 20 18:30:39 2023 +0000 refresh datacontext on change - now correctly refreshes the PublishPackageViewModel datacontext when publishing new package version commit ec0691e Author: Deyan Nenov <[email protected]> Date: Mon Nov 20 10:54:48 2023 +0000 replaced bullet menu icon - now uses vector path rather than png icon (scalable) commit 35377ca Merge: 626730f b658456 Author: Deyan Nenov <[email protected]> Date: Mon Nov 20 09:47:23 2023 +0000 Merge branch 'pm-publishpackage-packagecontents' into pm-mypackages-update commit b658456 Merge: 2be4bd5 96fb3f0 Author: Deyan Nenov <[email protected]> Date: Mon Nov 20 09:43:53 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 626730f Author: Deyan Nenov <[email protected]> Date: Thu Nov 16 08:37:45 2023 +0000 update mypackages ui and functionality - starting the work around MyPackages tab commit 2be4bd5 Author: Deyan Nenov <[email protected]> Date: Thu Nov 16 08:35:38 2023 +0000 remove commented out code commit 3396d3d Author: Deyan Nenov <[email protected]> Date: Wed Nov 15 20:03:42 2023 +0000 failing tests fix - the tests were failing because another test folder was starting with a preceding alphabet letter commit 40a0336 Merge: a9be281 723cef6 Author: Deyan Nenov <[email protected]> Date: Wed Nov 15 18:57:13 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit a9be281 Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 19:34:30 2023 +0000 remove unused icons commit bcb3971 Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 18:13:45 2023 +0000 restored deleted namespaces - not sure how the namespaces got wiped with the previous commit commit f733ae1 Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 17:50:09 2023 +0000 comments to public properties added commit be5fdcb Merge: 1ca1b6d 08e5d3f Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 17:39:14 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 1ca1b6d Merge: ab812d4 8af516c Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 11:16:53 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit ab812d4 Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 11:12:54 2023 +0000 remove duplicate icon.png from test folders - removed duplicate icon.png files / replaced with empty text files instead - updated tests that were failing since last changes commit 050c906 Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 10:18:44 2023 +0000 comment to PublishRetainFolderStructure - added a detailed comment describing the new PublishRetainFolderStructure method commit 43f0c08 Merge: 423691f f0cd05c Author: Deyan Nenov <[email protected]> Date: Tue Nov 14 10:03:24 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 423691f Author: Deyan Nenov <[email protected]> Date: Mon Nov 13 14:46:48 2023 +0000 fix commit 7cf3df8 Merge: c8b6f1f ec16645 Author: Deyan Nenov <[email protected]> Date: Mon Nov 13 12:20:12 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit c8b6f1f Merge: 00163ad caa3268 Author: Craig Long <[email protected]> Date: Thu Nov 9 15:23:30 2023 -0500 Merge branch 'master' into pm-publishpackage-packagecontents commit 00163ad Author: Deyan Nenov <[email protected]> Date: Wed Nov 8 14:16:36 2023 +0000 remove empty tooltips - remove unnecessary tooltip to the content presenter - added 1 missing tooltip to line items commit c6f8db0 Merge: 4432d8c c64fe07 Author: Deyan Nenov <[email protected]> Date: Wed Nov 8 12:35:20 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 4432d8c Author: Deyan Nenov <[email protected]> Date: Wed Nov 8 12:34:51 2023 +0000 new validation rules - updated validation rules as per Figma commit eb92b82 Author: Deyan Nenov <[email protected]> Date: Wed Nov 8 10:54:00 2023 +0000 starting space rule - no longer able to start with a space for all input fields - allows user to skip adding minor and build values will be replaced with default ones commit 6ba8920 Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 19:48:37 2023 +0000 numeric up/down fix and tests - added tests for numeric up/down - space is now handled and should not be allowed - new validation rule for package Name field commit 1564807 Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 14:22:16 2023 +0000 rework markdown path locator - added new control when no markdown path is selected commit df6e552 Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 13:41:25 2023 +0000 build version error message - added build version error message commit 817b28a Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 13:17:21 2023 +0000 host control updated - updated the host control visuals - tooltips update commit 3a56647 Merge: 4ffda43 b28faaa Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 12:19:59 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 4ffda43 Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 12:19:51 2023 +0000 keywords tags - added keywords tags - TODO: should we replace Kewords with KewordsCollection when submitting a package? commit 578c2c2 Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 10:45:31 2023 +0000 remove PublishPackageReadyToPublishPage - PublishPackageReadyToPublishPage was not used, removed commit 0487df0 Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 10:43:14 2023 +0000 tooltips - fixed tooltips and styles commit 88ed74a Author: Deyan Nenov <[email protected]> Date: Tue Nov 7 00:07:34 2023 +0000 description removed, name validation adorner added - removed description from package validation rules - added name error validation and adorner commit bf3e344 Author: Deyan Nenov <[email protected]> Date: Mon Nov 6 22:34:45 2023 +0000 exclude unmanaged dlls - unmanaged dll files cannot be Node Library - fixed Node Library preview commit d0df247 Author: Deyan Nenov <[email protected]> Date: Mon Nov 6 16:59:20 2023 +0000 publish retain folder done - finished workflow for publishing package reatining folder - changed UI finish screen to work differently depending on which workflow was taken - publish locally or online - tests added commit c1ff965 Merge: 9d6b738 0304338 Author: Deyan Nenov <[email protected]> Date: Mon Nov 6 10:41:41 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 9d6b738 Author: Deyan Nenov <[email protected]> Date: Sun Nov 5 14:07:03 2023 +0000 submit package retaining folder structure - created the second path to submitting packages online retaining folder structure - tests added commit c3bc444 Author: Deyan Nenov <[email protected]> Date: Wed Nov 1 20:35:55 2023 +0000 adding packagebuilder tests - adding tests for BuildRetainDirectory commit 2597eee Author: Deyan Nenov <[email protected]> Date: Tue Oct 31 14:24:00 2023 +0000 resources commit d7de724 Author: Deyan Nenov <[email protected]> Date: Tue Oct 31 12:22:27 2023 +0000 hover and tooltips - adding hover states - adding tooltips - removing old resources commit 04b8ff4 Author: Deyan Nenov <[email protected]> Date: Tue Oct 31 00:28:48 2023 +0000 resources commit f993ed8 Author: Deyan Nenov <[email protected]> Date: Mon Oct 30 23:01:06 2023 +0000 minor refactor commit a35b294 Author: Deyan Nenov <[email protected]> Date: Mon Oct 30 21:03:49 2023 +0000 rework of retain folder structure - change the logic of how to collect files under multiple root folders when using retain folder structure - keywords fix, added tests commit 2415b24 Merge: b287974 f665018 Author: Deyan Nenov <[email protected]> Date: Mon Oct 30 21:02:24 2023 +0000 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit b287974 Author: Deyan Nenov <[email protected]> Date: Mon Oct 30 15:11:18 2023 +0000 ui styling fixes - rework on the custom browser user control to correctly display dotted lines - no longer treats every assembly as NodeLibrary commit d57eb39 Author: Deyan Nenov <[email protected]> Date: Mon Oct 30 00:24:52 2023 +0000 fixed custombrowsercontrol visuals - multiple ui fixes to the custom browser control commit b17a4af Author: Deyan Nenov <[email protected]> Date: Sun Oct 29 18:50:33 2023 +0000 test remove multiple - added test to assert correct removal of multiple root items - publish package clears on window close without prompt - added ellipsis for package name - center message prompts to main view commit c3de2d7 Author: Deyan Nenov <[email protected]> Date: Sun Oct 29 13:51:14 2023 +0000 tests preview items structure to created package - tests added to assert preview package structure is identical to the created package structure commit c1bd03b Author: Deyan Nenov <[email protected]> Date: Sat Oct 28 20:31:48 2023 +0100 removing items more tests added - added more tests around removing items commit 27277f2 Merge: 3f573aa 4f279a9 Author: Deyan Nenov <[email protected]> Date: Sat Oct 28 14:59:20 2023 +0100 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 3f573aa Author: Deyan Nenov <[email protected]> Date: Tue Oct 24 15:40:40 2023 +0100 clear custom filepaths when clearing package controls - also clear custom definition filepaths commit 032b421 Merge: 96f7edc 892253e Author: Deyan Nenov <[email protected]> Date: Tue Oct 24 13:20:00 2023 +0100 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit 96f7edc Author: Deyan Nenov <[email protected]> Date: Tue Oct 24 13:18:54 2023 +0100 navigation way, cancel prompts - now warns the user of losing changes if using cancel or navigating away commit 5fec826 Author: Deyan Nenov <[email protected]> Date: Tue Oct 24 10:30:17 2023 +0100 retain folder structure - publish local retaining folder structure commit 6b83d44 Author: Deyan Nenov <[email protected]> Date: Mon Oct 23 18:58:29 2023 +0100 main flow finished - finished the main flow between the pages commit 3df4cce Author: Deyan Nenov <[email protected]> Date: Mon Oct 23 14:03:51 2023 +0100 clear data and ui - clearing data and ui after publishing - clearing data and ui with Cancel button commit 62c30b6 Author: Deyan Nenov <[email protected]> Date: Mon Oct 23 11:17:59 2023 +0100 consistent select all behavior - fixed checkbox behavior to be consistent when interacting with the rest of the controls commit 653461a Author: Deyan Nenov <[email protected]> Date: Sun Oct 22 20:35:04 2023 +0100 delete item tests added - added tests for delete item - fixed an issue where removing all items would not result in cleaning the RootContent items - added detailed description for the customTreeView_SelectedItemChanged method commit 5678922 Merge: e2cd0aa 989ea3c Author: Deyan Nenov <[email protected]> Date: Wed Oct 18 18:51:43 2023 +0100 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit e2cd0aa Author: Deyan Nenov <[email protected]> Date: Wed Oct 18 18:51:30 2023 +0100 customnode preview item added - we need the ability to display custom nodes as file with file paths during package creation. CustomDefinition does not have the attributes to address that, so we are adding a new 'preview' item type to server the purpose commit 0f281ab Author: Deyan Nenov <[email protected]> Date: Wed Oct 18 16:04:58 2023 +0100 assemblies show as files - assemblies now will show up with their file path, but still get picked up from their assembly resource on disk commit 05e7295 Author: Deyan Nenov <[email protected]> Date: Tue Oct 17 12:16:17 2023 +0100 browser sorting - now sorts browser alphabetically - fixed disabled behavior commit fbab436 Author: Deyan Nenov <[email protected]> Date: Tue Oct 17 10:09:22 2023 +0100 preview contents, bugfix - preview contents now correctly display based on user choice (retain folder or not) - fixed a bug where CustomDefinitions would read as root item - Pages are disabled when not displayed, in order to stop handling of tasks that affect other Pages commit db74c8b Author: Deyan Nenov <[email protected]> Date: Mon Oct 16 21:48:37 2023 +0100 remove inactive selection border background - ui tweaks commit 2ecd63a Author: Deyan Nenov <[email protected]> Date: Mon Oct 16 20:02:12 2023 +0100 item selection and deletion - UI added to allow users to add/remove items from current Package selection commit da0501f Author: Deyan Nenov <[email protected]> Date: Mon Oct 16 13:48:40 2023 +0100 delete folders working - changed `RemoveItem` method to account for folder items being removed - fixed a bug where removing an Assembly file would generate an error. Assembly files can also be added to 'additional items' commit 9901880 Author: Deyan Nenov <[email protected]> Date: Fri Oct 13 13:33:42 2023 +0100 testing preview functionality - added tests for the core methods of PreviewPackageBuild commit 4f704a7 Author: Deyan Nenov <[email protected]> Date: Tue Oct 10 15:16:15 2023 +0100 previewbuild started - started the structure for preview build commit f922975 Author: Deyan Nenov <[email protected]> Date: Mon Oct 9 22:09:11 2023 +0100 visual style tweaks - updated files and folders icons - now only allows LibraryNode checkboxes for Assembly dll files commit 45d558c Author: Deyan Nenov <[email protected]> Date: Mon Oct 9 20:12:27 2023 +0100 tests added - tests added to assert correct functionality of collecting files and folders commit 536d00f Author: Deyan Nenov <[email protected]> Date: Tue Oct 3 17:58:48 2023 +0100 wip commit 1cceb9e Author: Deyan Nenov <[email protected]> Date: Tue Oct 3 16:27:13 2023 +0100 tree visual update fix - using Dispatcher fixes the async tree creation commit a8fb2de Author: Deyan Nenov <[email protected]> Date: Tue Oct 3 14:21:51 2023 +0100 misc changes commit 24ce2cb Author: Deyan Nenov <[email protected]> Date: Mon Oct 2 22:53:26 2023 +0100 connected packagecontents and rootcontents commit 32fa036 Author: Deyan Nenov <[email protected]> Date: Mon Oct 2 22:12:01 2023 +0100 added pages - added pages for the wizard-like experience when publishing a package commit 0a0c1a6 Author: Deyan Nenov <[email protected]> Date: Mon Oct 2 16:11:15 2023 +0100 getting somewhere with browser - updated browser to only show root items commit b3aeee8 Author: Deyan Nenov <[email protected]> Date: Tue Sep 26 15:44:57 2023 +0100 folder structure - correctly creates minimum depth folder structure for the files added commit 183bdd7 Merge: ca46de8 6860810 Author: Deyan Nenov <[email protected]> Date: Mon Sep 18 17:06:35 2023 +0100 Merge remote-tracking branch 'upstream/master' into pm-publishpackage-packagecontents commit ca46de8 Author: Deyan Nenov <[email protected]> Date: Mon Sep 18 10:41:11 2023 +0100 colors in config.js - now all colors are controlled by the COLORS object in confing.js

mjkkirschner added 2 commits November 21, 2023 17:55

fix for null data being shown over and over

a7b7aef

fix issues with cli wrapper get data

cfc2520

mjkkirschner requested review from sm6srw, pinzart90 and aparajit-pratap November 22, 2023 00:39

mjkkirschner added 2 commits November 21, 2023 19:40

revert

7284bee

Merge branch 'master' of https://github.com/DynamoDS/Dynamo into cliw…

9372826

…rapperloop

sm6srw approved these changes Nov 22, 2023

View reviewed changes

mjkkirschner commented Nov 22, 2023

View reviewed changes

src/DynamoUtilities/Md2Html.cs Outdated Show resolved Hide resolved

pinzart90 reviewed Nov 22, 2023

View reviewed changes

src/DynamoUtilities/DynamoFeatureFlagsManager.cs Outdated Show resolved Hide resolved

pinzart90 reviewed Nov 22, 2023

View reviewed changes

src/DynamoUtilities/Md2Html.cs Outdated Show resolved Hide resolved

aparajit-pratap reviewed Nov 22, 2023

View reviewed changes

src/DynamoUtilities/DynamoFeatureFlagsManager.cs Outdated Show resolved Hide resolved

aparajit-pratap approved these changes Nov 22, 2023

View reviewed changes

add test

29471d6

pinzart90 reviewed Nov 22, 2023

View reviewed changes

src/DynamoUtilities/Md2Html.cs Outdated Show resolved Hide resolved

mjkkirschner added 2 commits November 22, 2023 17:13

review comments add tests

7957341

comments

8fcb4cd

QilongTang added this to the 3.0 milestone Nov 27, 2023

mjkkirschner changed the title ~~WIP fix performance issue with feature flags, and deadlock with CLI wrapper.~~ fix performance issue with feature flags, and deadlock with CLI wrapper. Nov 27, 2023

mjkkirschner changed the title ~~fix performance issue with feature flags, and deadlock with CLI wrapper.~~ DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. Nov 27, 2023

aparajit-pratap reviewed Nov 27, 2023

View reviewed changes

src/DynamoUtilities/Md2Html.cs Show resolved Hide resolved

aparajit-pratap approved these changes Nov 27, 2023

View reviewed changes

review comments

c78d6c6

pinzart90 approved these changes Nov 27, 2023

View reviewed changes

mjkkirschner merged commit cbba6d0 into DynamoDS:master Nov 27, 2023
16 checks passed

mjkkirschner deleted the cliwrapperloop branch November 27, 2023 16:26

aparajit-pratap mentioned this pull request Mar 14, 2024

Cherry-pick PRs 14703, 14637 #15020

Merged

9 tasks

mjkkirschner mentioned this pull request Mar 19, 2024

cherry pick CLI deadlock fix to 2.19.5 #15030

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. #14637

DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. #14637

mjkkirschner commented Nov 22, 2023 •

edited

Loading

mjkkirschner commented Nov 22, 2023 •

edited

Loading

sm6srw commented Nov 22, 2023

pinzart90 Nov 22, 2023

mjkkirschner Nov 22, 2023

mjkkirschner commented Nov 22, 2023 •

edited

Loading

DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. #14637

DYN-6412 fix performance issue with feature flags, and deadlock with CLI wrapper. #14637

Conversation

mjkkirschner commented Nov 22, 2023 • edited Loading

Purpose

Declarations

Release Notes

Reviewers

FYIs

mjkkirschner commented Nov 22, 2023 • edited Loading

sm6srw commented Nov 22, 2023

pinzart90 Nov 22, 2023

Choose a reason for hiding this comment

mjkkirschner Nov 22, 2023

Choose a reason for hiding this comment

mjkkirschner commented Nov 22, 2023 • edited Loading

mjkkirschner commented Nov 22, 2023 •

edited

Loading

mjkkirschner commented Nov 22, 2023 •

edited

Loading

mjkkirschner commented Nov 22, 2023 •

edited

Loading