Merge remote-tracking branch 'upstream/master' into pm-publishpackage…

…-packagecontents

.github/workflows/test.yml → .github/workflows/ui_smoke_tests.yml

@@ -1,4 +1,4 @@
-name: Test
+name: UI Smoke Tests
 
 on:
   workflow_run:
@@ -9,6 +9,12 @@ on:
 
 env:
   TEST_EXECUTE_DOWNLOAD_URL: https://downloads.smartbear.com/TestExecute1552SLM.exe
+  ACTOR: ${{ github.actor }}
+  WORKFLOW_ID: ${{ github.event.workflow_run.workflow_id }}
+  RUN_NAME: ${{ github.event.workflow_run.name }}
+  RUN_URL: ${{ github.event.workflow_run.html_url }}
+  PR_NUMBER: ${{ github.event.workflow_run.pull_requests[0].number }}
+  PR_URL: ${{ github.event.workflow_run.pull_requests[0].html_url }}
 
 jobs:
   ui_smoke_tests:
@@ -31,9 +37,9 @@ jobs:
         uses: dawidd6/action-download-artifact@v2
         with:
           name: DynamoSandbox
-          workflow: ${{ github.event.workflow_run.workflow_id }}
+          workflow: ${{ env.WORKFLOW_ID }}
           path: ${{ github.workspace }}\build
-      - name: Run Tests
+      - name: Run UI Smoke Tests
         shell: cmd
         run: .github\scripts\run_tests.bat ${{ secrets.TEST_EXECUTE_ACCESS_KEY }} Dynamo\Dynamo.pjs DynamoSandbox SmokeTests
       - name: UI Smoke Tests Report
@@ -43,9 +49,10 @@ jobs:
           name: UI Smoke Test Report
           path: reports/report.xml
           reporter: java-junit
-      - name: Action Summary
+      - name: Summary
         if: always()
         run: |
-          type summary.md | Out-File -FilePath $env:GITHUB_STEP_SUMMARY -Append
-          echo "" >> $GITHUB_STEP_SUMMARY
-          echo ":package: Trigerred by: [${{ github.event.workflow_run.name }}](${{ github.event.workflow_run.html_url }})" >> $env:GITHUB_STEP_SUMMARY
+          Get-Content summary.md >> $env:GITHUB_STEP_SUMMARY
+          Write-Output "Actor: @${{ env.ACTOR }}" >> $env:GITHUB_STEP_SUMMARY
+          Write-Output "Workflow Run: [${{ env.RUN_NAME }}](${{ env.RUN_URL }})" >> $env:GITHUB_STEP_SUMMARY
+          Write-Output "Pull Request: [${{ env.PR_NUMBER }}](${{ env.PR_URL }})" >> $env:GITHUB_STEP_SUMMARY

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Arc.ByBestFitThroughPoints.md

@@ -1,5 +1,8 @@
 ## In Depth
-Plane By Best Fit Through Points uses a set of points and finds the plane that best approximates the set. In the example, we use a series of RandomList components to generate random x,y and z coordinates. The points are created By Coordinates, and the list of points is then used as an input for ByBestFitThroughPoints.
+`Arc.ByBestFitThroughPoints` draws an arc that best represents 3 or more points. 
+
+In the example below, we create an arc that approximates a list of random points ranging from 0 to 5 in the X and Y directions.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Arc.ByThreePoints.md

@@ -1,5 +1,8 @@
 ## In Depth
-Plane by Three Points will create a plane that passes through the three input points. The points must not be co-linear. In the example below, we use three code blocks to define the three initial points, then use ByThreePoints to create a plane.
+`Arc.ByThreePoints` draws an arc from three points, given the start point, end point, and a point between them. 
+
+In the example below, we draw an arc from three randomly created points.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Arc.CenterPoint.md

@@ -1,5 +1,8 @@
 ## In Depth
-Center Point will return the center of an input sphere. In the example below, we use a ByBestFit node to create a sphere based on a set of random points. We then use a CenterPoint node to determine the center of the best fit sphere.
+`Arc.CenterPoint` returns a point at the center of an arc, the same point as the corresponding circle center. 
+
+In the example below, we create an arc from 3 randomly generated points, then return its center point with an `Arc.CenterPoint` node.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Arc.Radius.md

@@ -1,5 +1,8 @@
 ## In Depth
-Radius will return the center of an input sphere. In the example below, we use a ByBestFit node to create a sphere based on a set of random points. We then use a Radius node to determine the size of the best fit sphere.
+`Arc.Radius` returns the radius value of arc geometry. 
+
+In the example below, we create an arc from 3 randomly generated points, then return its radius point with an `Arc.Radius` node. We can visualize the change in radius as the input points change in the Y direction.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.BoundingBox.ByCorners.md

@@ -1,5 +1,8 @@
 ## In Depth
-Cuboid By Corners creates a cuboid where the two input points are used as the opposite corners of the cuboid. In the example file, two points are randomly generated and used to create a cuboid.
+`BoundingBox.ByCorners` creates a BoundingBox from two input points. 
+
+In the example below, we use the diagonal vector to translate the start point of the box to create its end point. To visualize the box, it is converted to a PolySurface and its edge curves are extracted.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.BoundingBox.ByGeometry.md

@@ -1,5 +1,8 @@
 ## In Depth
-ByGeometry brings each input geometry into Revit as an individual Import Instance element. An Import Instance is identified as an Import Symbol in Revit.
+`BoundingBox.ByGeometry` creates a BoundingBox around geometry.
+
+In the example below, a BoundingBox is created around a sphere. To visualize the box, it is converted to a cuboid and its edge curves are extracted.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Circle.ByBestFitThroughPoints.md

@@ -1,5 +1,8 @@
 ## In Depth
-Plane By Best Fit Through Points uses a set of points and finds the plane that best approximates the set. In the example, we use a series of RandomList components to generate random x,y and z coordinates. The points are created By Coordinates, and the list of points is then used as an input for ByBestFitThroughPoints.
+`Circle.ByBestFitThroughPoints` receives point inputs and creates a best-fit circle through them. 
+
+In the example below, a list of randomly generated points is used to generate a circle that best approximates them. We can dynamically increase and decrease the number of points with a number slider, altering the shape of the best-fit circle.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Circle.ByCenterPointRadius.md

@@ -1,5 +1,8 @@
 ## In Depth
-Sphere by Center Point Radius will create a sphere centered at the input point, and with an input radius. In the example below, we use a code block to specify the coordinates of a Point created by coordinates, and we use a number slider to determine the radius of the sphere.
+`Circle.ByCenterPointRadius` creates a circle with the Z-plane normal. 
+
+In the example below, we use a code block to create a point in three-dimensional space and locate the circle around the point. The radius is controlled dynamically with a number slider.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Circle.ByThreePoints.md

@@ -1,5 +1,8 @@
 ## In Depth
-Plane by Three Points will create a plane that passes through the three input points. The points must not be co-linear. In the example below, we use three code blocks to define the three initial points, then use ByThreePoints to create a plane.
+`Circle.ByThreePoints` receives 3 point inputs and creates a circle that passes through each point.
+
+In the example below, we use 3 randomly generated points on the Z-plane to create a circle.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Circle.CenterPoint.md

@@ -1,5 +1,8 @@
 ## In Depth
-Center Point will return the center of an input sphere. In the example below, we use a ByBestFit node to create a sphere based on a set of random points. We then use a CenterPoint node to determine the center of the best fit sphere.
+`Circle.CenterPoint` finds the center point of a given circle. 
+
+In the example below, we create a circle using `Circle.BestFitThroughPoints` and then extract the center point of the circle.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.Circle.Radius.md

@@ -1,5 +1,8 @@
 ## In Depth
-Radius will return the center of an input sphere. In the example below, we use a ByBestFit node to create a sphere based on a set of random points. We then use a Radius node to determine the size of the best fit sphere.
+`Circle.Radius` finds the radius of a given circle.
+
+In the example below, we create a circle using `Circle.ByBestFitThroughPoints` and then extract the radius of the circle.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.CoordinateSystem.ByOriginVectors(origin, xAxis, yAxis, zAxis).md

@@ -1,5 +1,8 @@
 ## In Depth
-Add in-depth information about ByOriginVectors (origin, xAxis, yAxis, zAxis)...
+`CoordinateSystem.ByOriginVectors (origin, xAxis, yAxis, zAxis)` returns a new CoordinateSystem at an input origin point with input X, Y, and Z axes. 
+
+In the example below, the CoordinateSystem is placed at an origin with new vectors for the X, Y, and Z axes. The result is a CoordinateSystem rotated relative to the original CoordinateSystem.
+
 ___
 ## Example File
 

doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.CoordinateSystem.ByPlane.md

@@ -1,5 +1,8 @@
 ## In Depth
-Sketch planes are used in the creation of 2D and 3D geometry in Revit.
+`CoordinateSystem.ByPlane` returns a new CoordinateSystem based on an input plane. 
+
+In the example below, the normal of the input plane has been repositioned, resulting in a new CoordinateSystem rotated about the X axis.
+
 ___
 ## Example File