Pm search for packages - versions updates #14355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- versions now a drop-down allowing to install selected version instead of always installing the latest - install to selected folder option resurrection - UI design updates as per Firgma
|
2 failing tests already fixed in this PR. I will mark this one as a |
|
Since #14352 is merged, this PR is now ready for review I assume? |
Yes, this one should now be good to go! |
QilongTang
approved these changes
Sep 11, 2023
|
@dnenov Two regressions since you touched search element: |
QilongTang
reviewed
Sep 11, 2023
9 tasks
- selected version property moved to the PackageManagerSearchElementViewModel
|
Triggered PR check manually at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/11148/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Package versions as a drop-down list allowing the user to install a specified version. Resurrected a feature (pre-2.19) allowing you to install the package in a specific folder.
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@reddyashish
FYIs
@Amoursol