Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm search for packages - search box control #14352

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Aug 30, 2023

Purpose

Small changes to the new search box control fixing the expected behavior to disable the search box while packages are being loaded. Also contains small UI changes as per the design outline in Figma.

UI Changes

search box update

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixed the expected behavior for the search box to be disabled while the packages are being loaded
  • UI changes as per Figma

Reviewers

@QilongTang
@Jingyi-Wen

FYIs

@Amoursol

- fixed the expected behavior for the search box to be disabled while the packages are being loaded
- UI changes as per Figma
@QilongTang QilongTang added this to the 3.0 milestone Sep 1, 2023
@QilongTang QilongTang merged commit 27cb79c into DynamoDS:master Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants