Pm search for packages - filters #14322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moving 'SearchForPackages' PR into smaller PRs - main chunk of work on the PackageManagerSearchControl -- context menu -- filter tags
- added all filters to the GetAllPackages routine
- removed the `active` filter - introduced `new` and `updated` as status filters
- added 'clear all' to resources
- no selected package when opening the package manager for the first time
- correctly assigned the `clear all` button text
- added tests for the new filters
- standardized ui element styles
- the user will be able to select multiple filters without the context menu closing
QilongTang
reviewed
Sep 6, 2023
QilongTang
reviewed
Sep 7, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Show resolved
Hide resolved
QilongTang
reviewed
Sep 8, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
- the two dependency filters (package 'has decency' and 'has no dependency') cannot be both in positive states - adjusted tests to take that change into account
QilongTang
reviewed
Sep 11, 2023
QilongTang
reviewed
Sep 11, 2023
src/DynamoCoreWpf/Views/PackageManager/Controls/FilterTagControl.xaml.cs
Show resolved
Hide resolved
QilongTang
reviewed
Sep 11, 2023
- added tooltips for all new filters, - updated old filters, - changed styling
- added comments for the public properties of the FilterTagControl
reddyashish
reviewed
Sep 13, 2023
src/DynamoCoreWpf/Views/PackageManager/Controls/FilterTagControl.xaml.cs
Outdated
Show resolved
Hide resolved
reddyashish
reviewed
Sep 13, 2023
| /// `Has Dependency` and `Has No Dependency` filters are mutually exclusive | ||
| /// </summary> | ||
| [Test] | ||
| public void PackageSearchDialogSearchTestDependencyFilters() |
There was a problem hiding this comment.
@dnenov Thank you for covering these tests.
reddyashish
reviewed
Sep 13, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Show resolved
Hide resolved
- replaced hard-coded string value with nameof property
QilongTang
reviewed
Sep 13, 2023
| //private bool showDeprecated; | ||
| //private bool showDependencies; | ||
| //private bool showNoDependencies; | ||
| //private bool isAnyFilterOn; |
There was a problem hiding this comment.
Can we remove this commented code?
There was a problem hiding this comment.
Yes, absolutely, sorry for the mess.
QilongTang
reviewed
Sep 13, 2023
There was a problem hiding this comment.
LGTM with one minor comment left. Also @dnenov can you remind me if we covered the fix that first time launching Dynamo PM the first package entry is always highlighted somewhere?
QilongTang
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Continuation of the work done on the Package Manager. This PR focuses on the implementation of new Filters in the first tab of the PM - the Search for Packages tab.
Filter tag bubbles added to the UI with the expected functionality.
UI Changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Sorting changed - default priority now to 'votesreverted back to last updateFilterTagbubble custom control createdclear allbutton clears all currently applied filtersFilterEntitybetween host and non-host filters (reusing the logic of the existing host filter VM as much as possible)has dependencyandhas no dependencyfilters toggle each other out, if positive (they are mutually exclusive)Reviewers
@QilongTang
@reddyashish
FYIs
@Amoursol