-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick: Update sample graphs #14267
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moDS#14224) * DYN-5918 Obsolete Google Analytics (DynamoDS#14213) * obsolete GA * revert * Updates * Update * Update * Clean-ups * updates * Update * Update
In Dynamo Revit is not returning the expected results when searching by category so in this fix instead of assigning a weight for all the fields (except for name) we will be assigning a weight individually for Name, Category, Description and SearchTags.
…hen a custom node is created (DynamoDS#14220) (DynamoDS#14227) * Fix note in group in customnode * add test * merge test from other PR Co-authored-by: Ashish Aggarwal <[email protected]>
* Display the proper language in the Splash Screen * spacing RootDirectories * Keeping spacing * Remove Splash Screen default title * Dissect the Preferences creation from the DynamoModel ctor * removing null validation * Refactoring based on the PathManager and Preferences * Adding a PathManager and Preference singleton * cleaning text * PathManager and PreferenceSetttings as singleton * Cleaning spacing and others * Using the singleton PathManager class instead of the Interface * Changing the scope and documenting the function CreateIPathResolver * Changing access to be flexible for integrators * Removing unused function * Setting the Preferences to the RecorderTests * Add the PreferenceSettings.Instance to the DynamoCoreTests setup * Adding the preference settings to the DynamoTestUIBase Start configuration * Set the Preferences to the SystemTesttBase * Set the PreferenceSettings.Instance to the DynamoViewModelUnitTest Start * Dealing with the PathResolver * Passing the Preferences to the DynamoModel Start function and update a comment * Passing the Prererences to the VisualizationTest Start * Update the MakeCLIModel function * Passing the Preferences to the DefaultStartConfiguration * Update AssemblySharedInfo.cs * Passing the settings to the configuration from the parameter * untouch the hostApplicationDirectory * Untouching the preLoadedLibraries field and renaming * Restoring fields and adding doc * Adding the preferences to the start of some tests * Validating the settings in the DynamoModelTestBase setup * Adding Preferences to the config Settings Test * Refactoring the PathManager and Preference creation on the DynamoModel ctor and DynamoModelTestBase * Cleaning Tests setup and ignore Pref Instance property for xml * Removing Pref Singleton to the CoreTest Setup * Rollback fron the 6213 commit * keep the StartInTestMode to false since this is an special case and set an explicit preferences instance * Handling Preferences * clieaning references * Saving them with the proper Unicode * Removing Singletion Preferences * Explicit Settings since the StartInTestMode is false * Add the specific Preferences * Rollback the cc58 * Rollback the cc58 * Fix Solution * Fixing the Assembly character and test file * Forcing to update the cc58 commit * Removing the test file * Fixing Tests Unicode * No new line --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> Co-authored-by: reddyashish <[email protected]>
* Revert "Nuget changes for internal published Nugets (DynamoDS#14204)" This reverts commit 4b5be5f. * Revert "Update (DynamoDS#14205)" This reverts commit 43fe6a7. * Revert "Nuget changes for NET60 public nugets (DynamoDS#14200)" This reverts commit 6794757. * clean up
* DYN-6052 Add node info event and API under DynamoServices package for ProtoCore (DynamoDS#14234) * Add node info event and API * Update * Update * clean up * remove line and column from InfoEntry * comments * clean up * clean up * update
* DYN-6094 Lucene unit testing (DynamoDS#14214) * Lucene unit testing * test updates * Update LuceneSearchUtility.cs * Update NodeAutoCompleteSearchViewModel.cs * Update NodeAutoCompleteSearchViewModel.cs * Test updates (cherry picked from commit 780f854) * Update SearchResultDataProvider.cs (DynamoDS#14253) Co-authored-by: pinzart <[email protected]> (cherry picked from commit aaf6a4e) --------- Co-authored-by: pinzart90 <[email protected]>
Due that we were using a StandardAnalyzer for Lucene searching we were not able to find some nodes in the results like "+", "*", "And". So I had to implement a Custom Analyzer so we will be using a specific Tokenizer that supports those special characters in the search term. Also I've added a Unit Test that validates if a set of specific nodes are found or not.
…namoDS#14265) * Rollback fron the 6213 commit * Rollback the cc58 * Reducing scope --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry pick #14266
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Update sample graphs.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of