Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(DYN-6137): failure expanding library sub categories #14242

Conversation

Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Aug 9, 2023

Untitled-min

Purpose

This PR is a fix to prevent unexpected behaviours related to expanding library sub categories after implementing forward delete functionality within nodes searching input.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@QilongTang

FYIs

@avidit

@QilongTang
Copy link
Contributor

@pinzart90 confirmed the reported regressions are not related to this PR. Merging

@QilongTang QilongTang merged commit 68b9ba4 into DynamoDS:master Aug 9, 2023
@QilongTang
Copy link
Contributor

@Enzo707 Please cherry-pick this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants