Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6053-Adjust-Lucene-Weights #14223

Merged
merged 1 commit into from
Aug 4, 2023
Merged

DYN-6053-Adjust-Lucene-Weights #14223

merged 1 commit into from
Aug 4, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Assigning a specific weight for each field (previously only node Name had a different weight) and increasing weight for Category..
In Dynamo Revit is not returning the expected results when searching by category so in this fix instead of assigning a weight for all the fields (except for name) we will be assigning a weight individually for Name, Category, Description and SearchTags.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Assigning a specific weight for each field (previously only node Name had a different weight) and increasing weight for Category..

Reviewers

@QilongTang @reddyashish

FYIs

In Dynamo Revit is not returning the expected results when searching by category so in this fix instead of assigning a weight for all the fields (except for name) we will be assigning a weight individually for Name, Category, Description and SearchTags.
@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Aug 3, 2023

This is a screenshot of the nodes shown before and after my fix (using Revit 2024)
image

@QilongTang QilongTang added this to the 2.19.0 milestone Aug 3, 2023
@QilongTang QilongTang merged commit 9947ba9 into DynamoDS:master Aug 4, 2023
QilongTang pushed a commit that referenced this pull request Aug 4, 2023
In Dynamo Revit is not returning the expected results when searching by category so in this fix instead of assigning a weight for all the fields (except for name) we will be assigning a weight individually for Name, Category, Description and SearchTags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants