-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Linter Extension and API public #13902
Make Linter Extension and API public #13902
Conversation
I think there are a few more things : |
Thinking of the minimal exposure needed for the upcoming DA check rules I think we only need internal abstract class LinterExtensionBase from the list above so let's add that and then LGTM @saintentropy |
@saintentropy @BogdanZavu @twastvedt We are going to release Dynamo 2.18 soon, is this one required? |
@QilongTang Yes please |
@saintentropy Please cherry-pick this to RC branch as well then |
* Make Linter base case public * Typos * Missing base class to public --------- Co-authored-by: Craig Long <[email protected]> (cherry picked from commit 5f7f7ea)
* Make Linter base case public * Typos * Missing base class to public --------- Co-authored-by: Craig Long <[email protected]> (cherry picked from commit 5f7f7ea) Co-authored-by: Craig Long <[email protected]>
Purpose
Expose the LinterExtensionBase as a public base class so that user can create linter extensions to create rule sets for Dynamo graphs beyond the GenerativeDesign type.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@BogdanZavu .
FYIs
@mjkkirschner @twastvedt