Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Linter Extension and API public #13902

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Make Linter Extension and API public #13902

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72b88b2
Make Linter base case public
saintentropy Apr 13, 2023
16cd228
Typos
saintentropy Apr 13, 2023
9226dd1
Missing base class to public
saintentropy Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/DynamoCore/Extensions/LinterExtensionBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace Dynamo.Extensions
/// <summary>
/// Base class for all LinterExtensions
/// </summary>
internal abstract class LinterExtensionBase : IExtension
public abstract class LinterExtensionBase : IExtension
{
private const string NODE_ADDED_PROPERTY = "NodeAdded";
private const string NODE_REMOVED_PROPERTY = "NodeRemoved";
Expand All @@ -26,9 +26,12 @@ internal abstract class LinterExtensionBase : IExtension
private LinterManager linterManager;
private HomeWorkspaceModel currentWorkspace;

internal ReadyParams ReadyParamsRef { get; set; }
public ReadyParams ReadyParamsRef { get; private set; }

internal bool IsActive => this.linterManager?.IsExtensionActive(UniqueId) ?? false;
/// <summary>
/// Is this linter currently active for the active workspace.
/// </summary>
public bool IsActive => this.linterManager?.IsExtensionActive(UniqueId) ?? false;

internal bool SetupComplete { get; set; } = false;

Expand Down Expand Up @@ -103,7 +106,7 @@ internal void Activate(bool linkToWorkspace = true)
internal void Deactivate()
{
//Nothing to deactivate if we have not setup everything properly
//yet or we alreay deativated this linter extension
//yet or we already deactivated this linter extension
if (!SetupComplete)
{
return;
Expand Down