Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick Linter API access changes to 2.18 #13933

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Apr 24, 2023

Purpose

cherry pick -> #13902

Expose the LinterExtensionBase as a public base class so that a user can create linter extensions to create rule sets for Dynamo graphs beyond the GenerativeDesign type.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

LinterExtensionBase is exposed as a public base class so that a extensions authors can create linter extensions to create rule sets for Dynamo graphs. The UI is available in Dynamo in the Graph Status view extension.

Reviewers

@BogdanZavu @QilongTang

FYIs

@mjkkirschner @twastvedt

saintentropy and others added 2 commits April 24, 2023 16:26
* Make Linter base case public

* Typos

* Missing base class to public

---------

Co-authored-by: Craig Long <[email protected]>
(cherry picked from commit 5f7f7ea)
@saintentropy saintentropy reopened this Apr 24, 2023
@saintentropy saintentropy changed the base branch from master to RC2.18.0_master April 24, 2023 21:20
@QilongTang
Copy link
Contributor

Reported regression is sporadic, merging

@QilongTang QilongTang merged commit 1932a36 into DynamoDS:RC2.18.0_master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants