Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-4465] Lock icon dimensions in library #12554

Merged

Conversation

SHKnudsen
Copy link
Contributor

Purpose

This PR fixes DYN-4465 by updating the librarie.min.js with the changes @alvpickmans made in this PR

LibraryBugFix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@QilongTang

FYIs

@Amoursol
@alvpickmans

@QilongTang QilongTang added this to the 2.13.1 milestone Jan 19, 2022
@QilongTang QilongTang merged commit 7b27cdf into DynamoDS:master Jan 19, 2022
QilongTang pushed a commit that referenced this pull request Jan 20, 2022
@QilongTang QilongTang mentioned this pull request Jan 20, 2022
8 tasks
QilongTang added a commit that referenced this pull request Jan 20, 2022
* Popup aligment (#12491)

* Upgrade DynamoSample rvt to 2023 after Revit DDFreeze. (#12507)

Co-authored-by: Ziyun Shang Application Admin <[email protected]>

* Fix collapase menu and popup position (#12501)

* DYN-4252-Shadow-Under-Pointer (#12503)

* DYN-4252-Shadow-Under-Pointer

I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines.
I had to add a Converter so a PointCollection can be converted to a Path.Data.

* DYN-4252-Shadow-Under-Pointer Code Review

Fixed one comment

* Update AnnotationViewModel.cs (#12537)

* Update librarie.min.js (#12554)

* Update AnnotationView.xaml (#12555)

* [DYN-4493] fix behavior with cleanup node layout feature and groups (#12535)

* Fix nested groups auto layout bug

* fix collapsed groups auto layout issue

* fix clean up node layout issue with collapsed groups

* Update AnnotationViewModel.cs

Co-authored-by: filipeotero <[email protected]>
Co-authored-by: ZiyunShang <[email protected]>
Co-authored-by: Ziyun Shang Application Admin <[email protected]>
Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Sylvester Knudsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants