Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-4339 Popup aligment right-handed #12491

Merged
merged 1 commit into from
Dec 15, 2021
Merged

DYN-4339 Popup aligment right-handed #12491

merged 1 commit into from
Dec 15, 2021

Conversation

filipeotero
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR fixes the popup's position when handedness settings are defined as right-handed.

menuDropAlignment

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Reviewers

@QilongTang

FYIs

@RobertGlobant20

@filipeotero filipeotero changed the title Popup aligment DYN-4339 Popup aligment right-handed Dec 14, 2021
QilongTang
QilongTang reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM But I may connect to understand this a bit better. I suspect we need to apply similar code somewhere else in Dynamo. Will reach out on standup

@QilongTang QilongTang merged commit 1f05ae8 into DynamoDS:master Dec 15, 2021
QilongTang pushed a commit that referenced this pull request Jan 20, 2022
@filipeotero @QilongTang
Popup aligment (#12491)
63cbd7b
@QilongTang QilongTang mentioned this pull request Jan 20, 2022
Merged
8 tasks
QilongTang added a commit that referenced this pull request Jan 20, 2022
@QilongTang @filipeotero
@ZiyunShang @RobertGlobant20 @SHKnudsen
RC2.13.1 initial cherrypicks (#12559)
6213399 
* Popup aligment (#12491)

* Upgrade DynamoSample rvt to 2023 after Revit DDFreeze. (#12507)

Co-authored-by: Ziyun Shang Application Admin <[email protected]>

* Fix collapase menu and popup position (#12501)

* DYN-4252-Shadow-Under-Pointer (#12503)

* DYN-4252-Shadow-Under-Pointer

I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines.
I had to add a Converter so a PointCollection can be converted to a Path.Data.

* DYN-4252-Shadow-Under-Pointer Code Review

Fixed one comment

* Update AnnotationViewModel.cs (#12537)

* Update librarie.min.js (#12554)

* Update AnnotationView.xaml (#12555)

* [DYN-4493] fix behavior with cleanup node layout feature and groups (#12535)

* Fix nested groups auto layout bug

* fix collapsed groups auto layout issue

* fix clean up node layout issue with collapsed groups

* Update AnnotationViewModel.cs

Co-authored-by: filipeotero <[email protected]>
Co-authored-by: ZiyunShang <[email protected]>
Co-authored-by: Ziyun Shang Application Admin <[email protected]>
Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Sylvester Knudsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipeotero @QilongTang