DYN-4252-Shadow-Under-Pointer #12503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines. I had to add a Converter so a PointCollection can be converted to a Path.Data.
QilongTang
reviewed
Jan 4, 2022
| Opacity="0.2" /> | ||
| </Polygon.BitmapEffect> | ||
| </Polygon> | ||
| <Path x:Name="TooltipPointer" |
There was a problem hiding this comment.
Can we update the comment above as well?
There was a problem hiding this comment.
@QilongTang comment fixed
d52c3d8
Fixed one comment
QilongTang
approved these changes
Jan 4, 2022
pinzart90
pushed a commit
that referenced
this pull request
Jan 5, 2022
* DYN-4252-Shadow-Under-Pointer I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines. I had to add a Converter so a PointCollection can be converted to a Path.Data. * DYN-4252-Shadow-Under-Pointer Code Review Fixed one comment
pinzart90
pushed a commit
that referenced
this pull request
Jan 5, 2022
* DYN-4252-Shadow-Under-Pointer I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines. I had to add a Converter so a PointCollection can be converted to a Path.Data. * DYN-4252-Shadow-Under-Pointer Code Review Fixed one comment
QilongTang
pushed a commit
that referenced
this pull request
Jan 20, 2022
* DYN-4252-Shadow-Under-Pointer I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines. I had to add a Converter so a PointCollection can be converted to a Path.Data. * DYN-4252-Shadow-Under-Pointer Code Review Fixed one comment
8 tasks
QilongTang
added a commit
that referenced
this pull request
Jan 20, 2022
* Popup aligment (#12491) * Upgrade DynamoSample rvt to 2023 after Revit DDFreeze. (#12507) Co-authored-by: Ziyun Shang Application Admin <[email protected]> * Fix collapase menu and popup position (#12501) * DYN-4252-Shadow-Under-Pointer (#12503) * DYN-4252-Shadow-Under-Pointer I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines. I had to add a Converter so a PointCollection can be converted to a Path.Data. * DYN-4252-Shadow-Under-Pointer Code Review Fixed one comment * Update AnnotationViewModel.cs (#12537) * Update librarie.min.js (#12554) * Update AnnotationView.xaml (#12555) * [DYN-4493] fix behavior with cleanup node layout feature and groups (#12535) * Fix nested groups auto layout bug * fix collapsed groups auto layout issue * fix clean up node layout issue with collapsed groups * Update AnnotationViewModel.cs Co-authored-by: filipeotero <[email protected]> Co-authored-by: ZiyunShang <[email protected]> Co-authored-by: Ziyun Shang Application Admin <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: Sylvester Knudsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Removing one side of the shadow in the Popup pointer.
I had to replace the Polygon (tree points connected by 3 lines) by a Path (tree points connected by 2 lines) due that the shadow was being applied to all sides of the Polygon(triangle), then now due that is a Path with 2 lines the shadow will be applied just in two lines, also I had to add a Converter so a PointCollection can be converted to a Path.Data.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Remove some part of the shadow that is part of the Popup pointer in Guided tours due that is giving the impression that is not part of the popup.
Reviewers
@QilongTang
FYIs
@filipeotero