Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector context menu lazy load #12091

Merged
merged 37 commits into from
Oct 4, 2021
Merged

Connector context menu lazy load #12091

merged 37 commits into from
Oct 4, 2021

Conversation

M-JULIANI
Copy link
Contributor

  • @saintentropy probably best to merge Wire connector UI modifications #12072 before this. We can handle any conflicts in this PR. Also we probably want to profile them separately to understand where we are/aren't getting performance improvements? I've never done that before but will speak to Ollie about getting some basic numbers done.

Description

This PR:

  • Separates out the connector ContextMenu from Connectors.xaml into a ConnectorContextMenuViewModel and associated view that gets created when right clicked, and set to null when mouse leaves or when an action is complete.
  • Styles the ContextMenu properly.

Wire-UI ContextMenu 29 09 2021

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@saintentropy
@QilongTang

FYIs

@SHKnudsen
@Amoursol

M-JULIANI and others added 30 commits September 27, 2021 14:50
@M-JULIANI
Polyline + thick outline removed.
fb342f0
@M-JULIANI
Removed 'ConnectorType` menu from view->connectors.
095af46
@M-JULIANI
Updated connector styles.
0c815b7
@M-JULIANI
New resources added/old ones removed. Minor UI updates to reflect moc…
389947b 
…kups.
@M-JULIANI
Merge branch 'master' into WireConnector-UI-Modifications
41e0b9e
@M-JULIANI
First commit.
85a5bba
@M-JULIANI
Cleanup. On-the-fly ContextMenu working.
2fcf08b
@M-JULIANI
Applying ContextMenu styling.
81b3c95
@M-JULIANI
Added (stole) ContextMenu styling.
648da3e
@M-JULIANI
Added resource strings to ContextMenu control.
1d855eb
@M-JULIANI
Update AssemblySharedInfo.cs
4f46d9d
@M-JULIANI
Unused ref removal.
7fbf5e8
@M-JULIANI
Cleanup.
e738d94
@M-JULIANI
Merge branch 'master' into Connector-ContextMenu-LazyLoad
55e752f
@M-JULIANI
Fixes.
41ac6a4
@M-JULIANI
First commit.
4f18a29
@M-JULIANI
Cleanup. On-the-fly ContextMenu working.
1e35f5d
@M-JULIANI
Applying ContextMenu styling.
2251ef1
@M-JULIANI
Added (stole) ContextMenu styling.
c74cd1b
@M-JULIANI
Added resource strings to ContextMenu control.
4111fba
@M-JULIANI
Update AssemblySharedInfo.cs
ffc4e5b
@M-JULIANI
Cleanup.
fa913c9
@filipeotero @M-JULIANI
Adding 10 to margin (DynamoDS#12076)
e39e683
@SHKnudsen @M-JULIANI
Update AnnotationModel.cs (DynamoDS#12086)
385cdb8
@saintentropy @M-JULIANI
Crash Fix. Add visibility trigger to empty tooltip strings. (DynamoDS…
909027b 
…#12069)

* Add visiblity trigger to empty tooltip strings

* PR comment

* Pr comments

Co-authored-by: Craig Long <[email protected]>
@sm6srw @M-JULIANI
DYN-3992: Upgrade LibG (DynamoDS#12060)
ae1c5c0
@aparajit-pratap @M-JULIANI
mark test as failure temporarily to fix build issues (DynamoDS#12090)
555fe6e
@SHKnudsen @M-JULIANI
add pins to groups (DynamoDS#12070)
fb9edf2 
* add pins to groups

* Update ConnectorPinView.xaml.cs
@sm6srw @M-JULIANI
Remove outdated logic (DynamoDS#12081)
11a1dff
@M-JULIANI
Wire connector UI modifications (DynamoDS#12072)
662fad9 
* Polyline + thick outline removed.

* Removed 'ConnectorType` menu from view->connectors.

* Updated connector styles.

* New resources added/old ones removed. Minor UI updates to reflect mockups.
SHKnudsen and others added 2 commits September 30, 2021 11:03
@M-JULIANI
Copy link
Contributor Author

@QilongTang one sec fixing a few things..

@M-JULIANI
Copy link
Contributor Author

OK fixes made @QilongTang.

@M-JULIANI
Copy link
Contributor Author

@QilongTang let me know if the Self-Serve is something on my end.

@QilongTang
Copy link
Contributor

QilongTang commented Oct 1, 2021 •
edited
Loading

@QilongTang let me know if the Self-Serve is something on my end.

Nope, those are tests failures from the test Oliver added for package manager which got disabled.

QilongTang
QilongTang reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, then LGTM

@M-JULIANI
Copy link
Contributor Author

@QilongTang unit tests added :)

@QilongTang
Copy link
Contributor

The regression list shown are not related to this PR. Merging.

DynamoCoreWpfTests.PackageManagerUITests.CannotCreateDuplicatePackageSearchDialogs
DynamoCoreWpfTests.PackageManagerUITests.CanOpenPackageSearchDialogAndWindowIsOwned
DynamoCoreWpfTests.PackageManagerUITests.PackageSearchDialogClosesWithDynamo

@QilongTang QilongTang merged commit a8f0b95 into DynamoDS:master Oct 4, 2021
@QilongTang QilongTang mentioned this pull request Oct 4, 2021
Merged
8 tasks
@QilongTang
Copy link
Contributor

I apologize, the three regressions are related to this PR, the fix is proposed in #12106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@M-JULIANI @QilongTang @filipeotero @SHKnudsen @saintentropy @sm6srw @aparajit-pratap @OliverEGreen