Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark test as failure temporarily to fix build issues #12090

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

aparajit-pratap
Copy link
Contributor

Purpose

Mark test added by @OliverEGreen as failure temporarily until we figure out the test regressions on build machines.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@aparajit-pratap aparajit-pratap merged commit b74168e into DynamoDS:master Sep 29, 2021
@aparajit-pratap aparajit-pratap deleted the skipTest branch September 29, 2021 16:14
M-JULIANI pushed a commit to M-JULIANI/Dynamo that referenced this pull request Sep 30, 2021
QilongTang added a commit that referenced this pull request Oct 4, 2021
* Polyline + thick outline removed.

* Removed 'ConnectorType` menu from view->connectors.

* Updated connector styles.

* New resources added/old ones removed. Minor UI updates to reflect mockups.

* First commit.

* Cleanup. On-the-fly ContextMenu working.

* Applying ContextMenu styling.

* Added (stole) ContextMenu styling.

* Added resource strings to ContextMenu control.

* Update AssemblySharedInfo.cs

* Unused ref removal.

* Cleanup.

* Fixes.

* First commit.

* Cleanup. On-the-fly ContextMenu working.

* Applying ContextMenu styling.

* Added (stole) ContextMenu styling.

* Added resource strings to ContextMenu control.

* Update AssemblySharedInfo.cs

* Cleanup.

* Adding 10 to margin (#12076)

* Update AnnotationModel.cs (#12086)

* Crash Fix.  Add visibility trigger to empty tooltip strings. (#12069)

* Add visiblity trigger to empty tooltip strings

* PR comment

* Pr comments

Co-authored-by: Craig Long <[email protected]>

* DYN-3992: Upgrade LibG (#12060)

* mark test as failure temporarily to fix build issues (#12090)

* add pins to groups (#12070)

* add pins to groups

* Update ConnectorPinView.xaml.cs

* Remove outdated logic (#12081)

* Wire connector UI modifications (#12072)

* Polyline + thick outline removed.

* Removed 'ConnectorType` menu from view->connectors.

* Updated connector styles.

* New resources added/old ones removed. Minor UI updates to reflect mockups.

* [DYN-4105] Make sure nodes gets added to parent group (#12084)

* make sure nodes gets added to parent group

* remove commented code

Co-authored-by: Aaron (Qilong) <[email protected]>

* Updates resource strings from Remove to Delete (#12088)

* Improved ContextMenu behaviour.

* PR fix.

* Removed unnecessary refs.

* Added unit tests for ConnectorContextMenu construction/disposal/commands.

Co-authored-by: filipeotero <[email protected]>
Co-authored-by: Sylvester Knudsen <[email protected]>
Co-authored-by: Craig Long <[email protected]>
Co-authored-by: Craig Long <[email protected]>
Co-authored-by: Jorgen Dahl <[email protected]>
Co-authored-by: aparajit-pratap <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Ollie Green <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant