Change DefaultWatch3DViewModel property - Active to virtual #11597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ZiyunShang
commented
Apr 8, 2021
| @@ -699,7 +699,10 @@ private void RenderPackageFactoryViewModel_PropertyChanged(object sender, Proper | |||
| // A full regeneration is required to get the edge geometry. | |||
| foreach (var vm in Watch3DViewModels) | |||
| { | |||
| vm.RegenerateAllPackages(); | |||
There was a problem hiding this comment.
BTW, I have used Dynamo 2.12.0 when I debug Dynamo code, I found that "Settings" had disappeared from the menu. I don't know how to toggle "ShowEdges" now.
There was a problem hiding this comment.
Thank you @ZiyunShang , we are doing a lot of UI improvements in Dynamo and indeed show edges are currently hidden. It will be back later but pending for implementation now.
QilongTang
reviewed
Apr 11, 2021
| @@ -699,7 +699,10 @@ private void RenderPackageFactoryViewModel_PropertyChanged(object sender, Proper | |||
| // A full regeneration is required to get the edge geometry. | |||
| foreach (var vm in Watch3DViewModels) | |||
| { | |||
| vm.RegenerateAllPackages(); | |||
| if (vm is HelixWatch3DViewModel) | |||
There was a problem hiding this comment.
hi @ZiyunShang Can you add comment to this type check as to why?
QilongTang
approved these changes
Apr 11, 2021
QilongTang
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
REVIT-166657
Some more info :
#9934
#9377
I have the same opinion with alfarok that when toggling "Revit Background Preview", it has no need to force a regeneration of the render packages for all nodes.
I think we can change "Active" to virtual, so it can be overridden in inherited classes.
I just have a change in DynamoRevit - DynamoDS/DynamoRevit#2687 and override Active property.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @aparajit-pratap
FYIs