Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DefaultWatch3DViewModel property - Active to virtual #11597

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Change DefaultWatch3DViewModel property - Active to virtual #11597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7af05aa
Change DefaultWatch3DViewModel property - Active to virtual
ZiyunShang Apr 8, 2021
8c8e42d
Add comment to ShowEdge changes.
ZiyunShang Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,10 @@ private void RenderPackageFactoryViewModel_PropertyChanged(object sender, Proper
// A full regeneration is required to get the edge geometry.
foreach (var vm in Watch3DViewModels)
{
vm.RegenerateAllPackages();
Copy link
Contributor Author

@ZiyunShang ZiyunShang Apr 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I have used Dynamo 2.12.0 when I debug Dynamo code, I found that "Settings" had disappeared from the menu. I don't know how to toggle "ShowEdges" now.
Capture

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ZiyunShang , we are doing a lot of UI improvements in Dynamo and indeed show edges are currently hidden. It will be back later but pending for implementation now.

if (vm is HelixWatch3DViewModel) // just need a full regeneration when vm is HelixWatch3DViewModel
{
vm.RegenerateAllPackages();
}
}
break;
case "MaxTessellationDivisions":
Expand Down
2 changes: 1 addition & 1 deletion src/DynamoCoreWpf/ViewModels/Watch3D/DefaultWatch3DViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public class DefaultWatch3DViewModel : NotificationObject, IWatch3DViewModel, ID
/// geometry updates. When set to False, the Watch3DView corresponding
/// to this view model is not displayed.
/// </summary>
public bool Active
public virtual bool Active
{
get { return active; }
set
Expand Down