Skip to content

Commit

Permalink
Change DefaultWatch3DViewModel property - Active to virtual (#11597)
Browse files Browse the repository at this point in the history
* Change DefaultWatch3DViewModel property - Active to virtual

* Add comment to ShowEdge changes.
  • Loading branch information
ZiyunShang authored Apr 12, 2021
1 parent 2f93542 commit 5160543
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,10 @@ private void RenderPackageFactoryViewModel_PropertyChanged(object sender, Proper
// A full regeneration is required to get the edge geometry.
foreach (var vm in Watch3DViewModels)
{
vm.RegenerateAllPackages();
if (vm is HelixWatch3DViewModel) // just need a full regeneration when vm is HelixWatch3DViewModel
{
vm.RegenerateAllPackages();
}
}
break;
case "MaxTessellationDivisions":
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public class DefaultWatch3DViewModel : NotificationObject, IWatch3DViewModel, ID
/// geometry updates. When set to False, the Watch3DView corresponding
/// to this view model is not displayed.
/// </summary>
public bool Active
public virtual bool Active
{
get { return active; }
set
Expand Down

0 comments on commit 5160543

Please sign in to comment.