Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-3512] Dynamo Menu's UX Update #11526

Merged
merged 49 commits into from
Mar 3, 2021

Conversation

Astul-Betizagasti
Copy link
Contributor

@Astul-Betizagasti Astul-Betizagasti commented Mar 2, 2021

Purpose

Update the Dynamo app menus to the new design

2

1

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

Aaron Tang (@QilongTang )

FYIs

Alfredo Pozo (@alfredo-pozo )
Roberto Tellez (@RobertGlobant20 )

Astul-Betizagasti and others added 30 commits July 6, 2020 17:48
Master update from public repo
/// Sets the visibility of the preferences menu option inside the Dynamo menu
/// The option will be disabled if in debug mode
/// </summary>
public bool IsVisiblePreferences
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use converter https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/UI/Converters.cs? Any new property here may end up being APIs we do not intend to expose...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will look into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! Thanks for the comment, I didn't know about that converters.cs file before

@mjkkirschner
Copy link
Member

could we also add a screenshot of how this looks to the PR for reference?

@QilongTang
Copy link
Contributor

could we also add a screenshot of how this looks to the PR for reference?

Yes, requested on standup

@QilongTang
Copy link
Contributor

Hi @Astul-Betizagasti Did you talk to @RobertGlobant20 about #11517 yet? I think that is what I mean to hide over a specific debug mode.

@QilongTang
Copy link
Contributor

Thanks @Astul-Betizagasti , since all the images icons are removed, can you also investigate if there is way to make the menu item look as the design (with no space before each item).

This PR LGTM

@QilongTang QilongTang merged commit e88fb3c into DynamoDS:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants