-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DYN-3512] Dynamo Menu's UX Update #11526
Conversation
update master
update master
This reverts commit c78dfe9.
Update master
Update master
Master update from public repo
Update master
master update
Update master
Update master
Update master
Update master
Update branch
update master
Update master
update master
Update master branch
Update master
update master
update branch
Update branch
Update master
update master
Update Branch
Update master
/// Sets the visibility of the preferences menu option inside the Dynamo menu | ||
/// The option will be disabled if in debug mode | ||
/// </summary> | ||
public bool IsVisiblePreferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use converter https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/UI/Converters.cs? Any new property here may end up being APIs we do not intend to expose...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! Thanks for the comment, I didn't know about that converters.cs file before
could we also add a screenshot of how this looks to the PR for reference? |
Yes, requested on standup |
Hi @Astul-Betizagasti Did you talk to @RobertGlobant20 about #11517 yet? I think that is what I mean to hide over a specific debug mode. |
Thanks @Astul-Betizagasti , since all the images icons are removed, can you also investigate if there is way to make the menu item look as the design (with no space before each item). This PR LGTM |
Purpose
Update the Dynamo app menus to the new design
Declarations
Check these if you believe they are true
*.resx
filesReviewers
Aaron Tang (@QilongTang )
FYIs
Alfredo Pozo (@alfredo-pozo )
Roberto Tellez (@RobertGlobant20 )