update master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new param key to execute session add test add data when execute session is created * add python usage test * remove using * add todo
When unmarhsalling output data from a Python script using the CPython engine, a StackOverlowException would occur for certain uncommon types. The unmarshaller is trying to recursively convert the output by calling 'AsManagedObject', but in cases where Python.NET does not have a specialized representation, like it is the case for 'weakref', it just returns a different object pointing to the same handle. This is causing the unmarshaller to call himself again with basically the same underlying Python object, triggering the stack overflow. The problem is fixed by explicitly checking if the returned object by 'AsManagedObject' has the same handle as the original one, in which case an exception is thrown with a proper message.
Adds tests for the following conversion scenarios: - Python list => .NET IList (CPython fails) - .NET array => Python list - Python tuple => .NET array - Python tuple => .NET IList (CPython fails) - Python range => .NET array - Python range => .NET IList (CPython fails) - Python dict => .NET IDictionary (CPython fails) - .NET IDictionary => Python dict (CPython unkonwn) Also commented out some tests that fail in both engines but may be considered to fix in CPython: - .NET IList => Python list (call a Python list method on an IList?) - Python array => .NET IList (builtin library, may be uncommon) - Python dict => DS Dictionary (may deserve special attention) Other types considered but not added as tests: - classes (can't convert them) - dictionary view objects (uncommon) - bytes, bytearray, memoryview (uncommon) - set, frozenset (uncommon) - complex (uncommon) Other scenarios that might be interesting: - Mutability of collections (IronPython supports this for a IList)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.