Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master #7

Merged
merged 5 commits into from
Jul 10, 2020
Merged

Conversation

Astul-Betizagasti
Copy link
Owner

No description provided.

QilongTang and others added 5 commits July 10, 2020 12:57
* Regressions

* code cleanup
* UpdateBoundaryFromSelection Fix

* Fix

* Comment spelling correction

* Performance changes

* Revert note hight changes

* Revert "Revert note hight changes"

This reverts commit aceaffa.

* Removal of note check

Co-authored-by: Astul B <[email protected]>
* Removal of unused code

* Revert "Removal of unused code"

This reverts commit c78dfe9.

* Added Obsolete Tag

* Message change

* Tests1

* Tests changes
* Added tests for NodeModel

* Added tests for NodeModel

* Revert "Added tests for NodeModel"

This reverts commit 4434d5f.

* Update NodeModelTests.cs

* Removed a test and marked the properties as obsolete

* Changed Obsolete for IsObsolete applying it only to the setter

* Updated message

* Added tests for NodeModel

* Deprecated PrintExpression and removed the associated test.

* DYN-2561 - Coverage Connectors folder

I added the ConnectorModelConnectTest() method to increase the coverage in the ConnectorModel class.

The  internal class InvalidPortException was deleted due that is no used (no reference was found in all the Dynamo solution). I got approval from Aaron and Michael in the Autodesk Slack Channel.

For the DeserializeCore(XmlElement nodeElement, SaveContext context) I deleted the commented code. I got approval from Aaron and Michael in the Autodesk Slack Channel.

* Added tests for Attributes

* Replaced a string with its associated resource.

Co-authored-by: Roberto Tellez <[email protected]>
Adds support to convert any Python iterable to an IList or IEnumerable
in the context of a function call using the CPython engine. The decoder
now checks if the PyObject returned is iterable instead of a sequence,
which is supported by the function we are using in Python.NET. Also,
IEnumerable, both generic and non-generic, is declared as a target type
to allow more conversion scenarios.

This should now allow converting dictionary view types, set and
frozenset to IList. It should also allow these and any other types that
are iterable (list, tuple, dictionary) to be converted to IEnumerable.
@Astul-Betizagasti Astul-Betizagasti merged commit ec787fa into Astul-Betizagasti:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants