Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround on Uri.fsPath getting '/' (slash) prefix #316

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Workaround on Uri.fsPath getting '/' (slash) prefix #316

merged 3 commits into from
Sep 26, 2018

Conversation

ole1986
Copy link
Contributor

@ole1986 ole1986 commented Aug 28, 2018

Alternate to PR #314 which should make the fixFileUrl unnecessary I guess
I assume some path modification take place before fsPath() got initially called.

So the call immediately after Uri.file([...]) is called fixes it for me.

More details on _makeFsPath here:
https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/uri.ts#L547

May also fix #307, #296, #297 and others.

@ole1986
Copy link
Contributor Author

ole1986 commented Aug 31, 2018

Unofficial release (for testing purposes only):
githistory-0.4.3.vsix
https://expirebox.com/download/0e02f960108d774e214d762db83144f8.html

Link will expire in 2 days

@stamminator
Copy link

stamminator commented Sep 7, 2018

One of the most popular VS Code extensions, with 3.3 million views, has had one of its core features totally broken for months, and PRs aiming to fix it have just been sitting and waiting. What will it take to get some action on this?

@ole1986 Can you share a non-expiring link? A read-only link to the vsix file on a cloud storage service would do the trick.

@ole1986
Copy link
Contributor Author

ole1986 commented Sep 8, 2018

I have reuploaded on my server(s):
https://www.cloud86.de/sdm_downloads/git-history-v0-4-3-unofficial-release/

Explanation on how to install the VSIX can be found here:
https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix

UPDATE: Removed download due to returning activity

@hussem1
Copy link

hussem1 commented Sep 21, 2018

@DonJayamanne This is opened since 23 days now. its a fix for a core functionality, is there anything that can be done to move it forward?
Thank you.

@ole1986
Copy link
Contributor Author

ole1986 commented Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Compare against previous version" doesn't work
4 participants