0.4.2 new issue finding files for diff #297

RevFry · 2018-07-17T17:53:18Z

When I try to view and compare against file in my work space I get an error dialog that says, "Corresponding work space file does not exist".

I think the cause is related to the this other issue. When I try to compare against a previous version I see an error in the output that says "fatal: '../../C:/[pathtofile]/[file]' is outside repository"

Looks like it's prepending unnecessarily to an already fully qualified path.

DonJayamanne · 2018-07-17T18:14:02Z

Please could you send a sample repo with details to replicate this issue. Thanks.

RevFry · 2018-07-17T18:17:15Z

I'll try and locate one to use. Everything I usually work on comes from private repositories. I'll add a comment when I have an example repository.

RevFry · 2018-07-17T18:27:00Z

I actually cloned your repo and tried it.

To make sure I uninstalled the extension, deleted the folder, installed it, reloaded and then attempted to compare git.ts to previous and work space.

JWleo · 2018-07-18T01:30:22Z

me too.
os: win10
vscode: 1.25.1
git history: 0.4.2
@DonJayamanne same as upstairs @RevFry

the ability of compare to previous or workspace has something wrong

marchage · 2018-07-23T13:04:22Z

Oh but this means I have to use... 🥁 ...

⚡ (?! [A-Z]+) 💥 !!! ⚡

_{your (this || that || ...) code editor and/or git log gui client}

😱 nooohhhhwww...!

This extension shows timeline graphics among git chaos (👍 ), while using Visual Studio code --disable-gpu. For me at least.

stamminator · 2018-07-23T14:06:17Z

Same for me, can't do file diffs at all

git show 83e0d3a8852c41145d3a5a5200854dda808ffe48:../../../../../c:/Users/JStamm/Documents/GitHub/piranha.core.examples/AddBlogToMvcApplication/Startup.cs  (completed in 0.363s)

fatal: '../../../../../c:/Users/JStamm/Documents/GitHub/piranha.core.examples/AddBlogToMvcApplication/Startup.cs' is outside repository

stuartZhang · 2018-07-24T10:27:38Z

I have run across the same issue as well.

Moreover, I'd like to contribute more useful information for the issue:

Duplicate the git command "git show daefed355709ab1abc070ab706400a50eceea3c0:../../../d:/workshop/github/mobile_attendance/src/modules/attendance/pages/Edit.vue" from the Output panel.
Rewrite the git command to "git show daefed355709ab1abc070ab706400a50eceea3c0:src/modules/attendance/pages/Edit.vue"
Execute the new command in the VSCode Internal Terminal. The git-diff becomes available.

As a result, I doubt whether the git command "git show ***" is incorrectly built.

AdrianCuartas · 2018-08-01T06:19:15Z

I'm having the same issue.

RevFry · 2018-08-07T15:49:23Z

Oddly, this doesn't seem to be constant. Today I was frustrated and kept clicking compare to previous and at one point it just worked. I didn't make any changes or even leave that window. Just tried it multiple times.

hussem1 · 2018-08-08T20:27:34Z

+1 I am seeing the same issues

git show --pretty=oneline --decorate=full --numstat f4728459bdb0ff087e529b8accd0163f72aa726a  (completed in 0.151s)
git show --numstat --pretty=oneline -M f4728459bdb0ff087e529b8accd0163f72aa726a  (completed in 0.137s)
git show --name-status --pretty=oneline -M f4728459bdb0ff087e529b8accd0163f72aa726a  (completed in 0.145s)
git remote get-url origin  (completed in 0.153s)
git log --pretty=oneline f4728459bdb0ff087e529b8accd0163f72aa726a^1 -n 1 -- ..\..\..\..\..\c:\Users\hussem1\Documents\Projects\DemoProject\README.md  (completed in 0.142s)
fatal: ..\..\..\..\..\c:\Users\hussem1\Documents\Projects\DemoProject\README.md: '..\..\..\..\..\c:\Users\hussem1\Documents\Projects\DemoProject\README.md' is outside repository

pacher · 2018-09-03T10:43:00Z

+1 having issue

lavaner · 2018-09-19T02:31:25Z

+1 same issue

azhukov87 · 2018-09-20T14:56:49Z

+1 to issue having

JWleo · 2018-09-20T15:08:26Z

guys! if you have the same problem on WINDOWS, you could get your answer at #316 . Install that unofficial git-history-vscode, and it will work for this function

ole1986 · 2018-09-20T16:10:15Z

@JWleo thank you for telling others about the PR

but, better you change "gays" to "guys" in your sentence ;-)

hussem1 · 2018-09-21T00:23:28Z

@JWleo vsix is no longer available for download.

JWleo · 2018-09-21T00:44:38Z

@hussem1 https://www.cloud86.de/sdm_downloads/git-history-v0-4-3-unofficial-release/
@ole1986

hussem1 · 2018-09-21T00:45:52Z

It says

The page could not be found.
Nothing was found at this point. Try a search or try the links below

JWleo · 2018-09-22T01:26:25Z

@hussem1 May be something wrong about your internet.

MJayyusi · 2018-09-22T06:43:08Z

@JWleo Thank you, I downloaded and tested it. Works great. I hope this gets merged soon.

Alternate to PR #314 which should make the fixFileUrl unnecessary I guess I assume some path modification take place before fsPath() got initially called. So the call immediately after Uri.file([...]) is called fixes it for me. More details on _makeFsPath here: https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/uri.ts#L547 May also fix #307, #296, #297 and others.

ole1986 · 2018-10-01T20:25:00Z

This issue should be fixed with version 0.4.3, too

giammi56 · 2020-10-23T17:14:12Z

the issue is still there

ole1986 · 2020-10-23T17:28:04Z

@giammi56 feel free to please raise a new issue with some log and environment details. Thank you

RevFry mentioned this issue Jul 26, 2018

git show fails with "is outside repository" #301

Closed

This was referenced Aug 12, 2018

"Compare against previous version" doesn't work #307

Closed

Fix fixFileUri() on Windows #314

Closed

ole1986 mentioned this issue Aug 28, 2018

Workaround on Uri.fsPath getting '/' (slash) prefix #316

Merged

ole1986 closed this as completed Oct 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.4.2 new issue finding files for diff #297

0.4.2 new issue finding files for diff #297

RevFry commented Jul 17, 2018 •

edited

Loading

DonJayamanne commented Jul 17, 2018 •

edited

Loading

RevFry commented Jul 17, 2018

RevFry commented Jul 17, 2018

JWleo commented Jul 18, 2018 •

edited

Loading

marchage commented Jul 23, 2018 •

edited

Loading

stamminator commented Jul 23, 2018

stuartZhang commented Jul 24, 2018 •

edited

Loading

AdrianCuartas commented Aug 1, 2018

RevFry commented Aug 7, 2018

hussem1 commented Aug 8, 2018

pacher commented Sep 3, 2018

lavaner commented Sep 19, 2018

azhukov87 commented Sep 20, 2018

JWleo commented Sep 20, 2018 •

edited

Loading

ole1986 commented Sep 20, 2018

hussem1 commented Sep 21, 2018

JWleo commented Sep 21, 2018

hussem1 commented Sep 21, 2018

JWleo commented Sep 22, 2018

MJayyusi commented Sep 22, 2018

ole1986 commented Oct 1, 2018

giammi56 commented Oct 23, 2020

ole1986 commented Oct 23, 2020

0.4.2 new issue finding files for diff #297

0.4.2 new issue finding files for diff #297

Comments

RevFry commented Jul 17, 2018 • edited Loading

DonJayamanne commented Jul 17, 2018 • edited Loading

RevFry commented Jul 17, 2018

RevFry commented Jul 17, 2018

JWleo commented Jul 18, 2018 • edited Loading

marchage commented Jul 23, 2018 • edited Loading

⚡ (?! [A-Z]+) 💥 !!! ⚡

your (this || that || ...) code editor and/or git log gui client

stamminator commented Jul 23, 2018

stuartZhang commented Jul 24, 2018 • edited Loading

AdrianCuartas commented Aug 1, 2018

RevFry commented Aug 7, 2018

hussem1 commented Aug 8, 2018

pacher commented Sep 3, 2018

lavaner commented Sep 19, 2018

azhukov87 commented Sep 20, 2018

JWleo commented Sep 20, 2018 • edited Loading

ole1986 commented Sep 20, 2018

hussem1 commented Sep 21, 2018

JWleo commented Sep 21, 2018

hussem1 commented Sep 21, 2018

JWleo commented Sep 22, 2018

MJayyusi commented Sep 22, 2018

ole1986 commented Oct 1, 2018

giammi56 commented Oct 23, 2020

ole1986 commented Oct 23, 2020

RevFry commented Jul 17, 2018 •

edited

Loading

DonJayamanne commented Jul 17, 2018 •

edited

Loading

JWleo commented Jul 18, 2018 •

edited

Loading

marchage commented Jul 23, 2018 •

edited

Loading

_{your (this || that || ...) code editor and/or git log gui client}

stuartZhang commented Jul 24, 2018 •

edited

Loading

JWleo commented Sep 20, 2018 •

edited

Loading