Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Compare against previous version" doesn't work #307

Closed
dodok8 opened this issue Aug 8, 2018 · 18 comments · Fixed by #316
Closed

"Compare against previous version" doesn't work #307

dodok8 opened this issue Aug 8, 2018 · 18 comments · Fixed by #316

Comments

@dodok8
Copy link

dodok8 commented Aug 8, 2018

When I use VS code and gitHistory on git repository save in USB flash drive(F:), "Compare against previous version" doesn't work.
It returns error message like

git log --pretty=oneline 6a210d55a11636791bba18da0308527c462efc76^1 -n 1 -- C:\f:\study\PythonAlgorithmStudy\"Baekjoon\1328_\352\263\240\354\270\265 \353\271\214\353\224\251v1.py"  (completed in 0.318s)
fatal: Invalid path 'C:/f:': No such file or directory

Original file name is 1328_고층 빌딩v1.py.

@MadaoChen
Copy link

I have the same problem

@tonyoldfield
Copy link

Same here.

@kerhbal
Copy link

kerhbal commented Aug 12, 2018

same here

@RevFry
Copy link

RevFry commented Aug 12, 2018

Yeah issue #297 I opened it a month ago. For some reason everyone is having their project paths prepended with C: or /..

@gutmate
Copy link

gutmate commented Aug 12, 2018

same here

@iamvips
Copy link

iamvips commented Aug 13, 2018

Compare against previous version" doesn't work for me too. I am on Windows VS Code 1.25.1 and it doesn't show me the changes done in the selected file and prints a message to Output as the "file is outside repository" which is incorrect as this worked completely fine after degrading my VS Code to 1.24.1 version. Hoping the fix at the earliest. Thank you in advance.

@AmitKKhanchandani
Copy link

Same here, Any Fixes?

@AmitKKhanchandani
Copy link

@DonJayamanne any update regarding this?

@Britford
Copy link

Same problem.
git show xxxx:C:/e:/xxx/index.html (completed in 0.046s)
fatal: Path 'C:/e:/xxx/index.html does not exist in xxx
Renders addon useless.

@erwanpoupard
Copy link

Same here with windows 10 and v1.26.1

@skydever
Copy link

... same here:

git log --pretty=oneline -n1 4b3b1bc7758d913f92eacac3fdcd06840fb3495c  (completed in 0.165s)
git show --pretty=oneline --decorate=full --numstat 4b3b1bc7758d913f92eacac3fdcd06840fb3495c  (completed in 0.36s)
git show --numstat --pretty=oneline -M 4b3b1bc7758d913f92eacac3fdcd06840fb3495c  (completed in 0.153s)
git show --name-status --pretty=oneline -M 4b3b1bc7758d913f92eacac3fdcd06840fb3495c  (completed in 0.182s)
git remote get-url origin  (completed in 0.064s)
git log --pretty=oneline 4b3b1bc7758d913f92eacac3fdcd06840fb3495c^1 -n 1 -- C:\d:\projects\some-path\a-file.js  (completed in 0.166s)
fatal: Invalid path 'C:/d:': No such file or directory

git show 4b3b1bc7758d913f92eacac3fdcd06840fb3495c:C:/d:/projects/some-path/a-file.js  (completed in 0.155s)
fatal: Path 'C:/d:/projects/some-path/a-file.js' does not exist in '4b3b1bc7758d913f92eacac3fdcd06840fb3495c'

@ole1986
Copy link
Contributor

ole1986 commented Aug 31, 2018

PR #316 has an unofficial release posted.
Would be really helpful to know if the PR also fixes this issue

@ZippoLee12138
Copy link

Same here

@JWleo
Copy link

JWleo commented Sep 11, 2018

it works on linux!

@ole1986
Copy link
Contributor

ole1986 commented Sep 11, 2018

@JWleo it would be good to know if th unofficial release from PR #316 also works for you.

By chance, can you test it?!

@JWleo
Copy link

JWleo commented Sep 11, 2018

@ole1986 Fine. I will tell you about the result after testing.

@JWleo
Copy link

JWleo commented Sep 13, 2018

@ole1986 yeah,Cool!!!!!! It works on window10 by using your VSIX file to update the office realese0.42. Thanks.
The office realese 0.42 is just fine on linux, so i don't need to install your VSIX file.

@dodok8 dodok8 closed this as completed Sep 16, 2018
DonJayamanne pushed a commit that referenced this issue Sep 26, 2018
Alternate to PR #314  which should make the fixFileUrl unnecessary I guess
I assume some path modification take place before fsPath() got initially called.

So the call immediately after Uri.file([...]) is called fixes it for me.

More details on _makeFsPath here:
https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/uri.ts#L547

May also fix #307, #296, #297 and others.
@skydever
Copy link

skydever commented Oct 1, 2018

I am still facing this issue, is this already part of the current release?

fatal: Invalid path 'C:/d:': No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet