Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the deprecation notice #206

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Jul 23, 2019

Deprecations added in #203 introduced a lot of confusion (see: #204 (comment) and #204 (comment)). This PR adds an actionable fix to the deprecation notice.

Closes #193

cc: @pichfl @willviles

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@snewcomer snewcomer merged commit ac041be into DockYard:master Jul 23, 2019
@willviles
Copy link

Thanks @CvX!

@pichfl
Copy link
Contributor

pichfl commented Jul 24, 2019

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HistoryLocation Subclass Question
4 participants