Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate locations/router-scroll for Embers own implementation #203

Merged
merged 2 commits into from
Jun 15, 2019
Merged

Deprecate locations/router-scroll for Embers own implementation #203

merged 2 commits into from
Jun 15, 2019

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Jun 14, 2019 •
edited
Loading

@snewcomer snewcomer self-assigned this Jun 14, 2019
@snewcomer snewcomer requested review from jleja and Serabe June 14, 2019 18:31
Serabe
Serabe approved these changes Jun 14, 2019
View reviewed changes
Copy link

@Serabe Serabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jleja
jleja approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@jleja jleja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop!

@snewcomer snewcomer merged commit 695d894 into master Jun 15, 2019
@snewcomer snewcomer deleted the sn/deprecate-location-object branch June 15, 2019 20:31
@CvX CvX mentioned this pull request Jul 23, 2019
Merged
@snewcomer snewcomer mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleja jleja jleja approved these changes

@Serabe Serabe Serabe approved these changes

Assignees

@snewcomer snewcomer

Labels
breaking enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snewcomer @Serabe @jleja