Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #204

Merged
merged 4 commits into from
Jul 24, 2019
Merged

Release 1.2.0 #204

merged 4 commits into from
Jul 24, 2019

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Jun 17, 2019

close #200 #193

@snewcomer snewcomer requested a review from jleja June 17, 2019 16:29
@snewcomer snewcomer self-assigned this Jun 17, 2019
@snewcomer snewcomer requested a review from duggiefresh June 17, 2019 23:05
@pichfl
Copy link
Contributor

pichfl commented Jul 14, 2019

How would one fix the deprecation introduced in this release? I feel like I'm missing a step here.

@williamweckl
Copy link

@pichfl the fixes has already being made. This PR only releases it.

@snewcomer any expectations to release that?

@pichfl
Copy link
Contributor

pichfl commented Jul 14, 2019

Hence why I'm asking. Installing this release will result in deprecation warnings without a clear path on how to fix them. The text inside the warning is not helpful for consumers of the add-on.

If I'm wrong, please point me and other people running into the same deprecation into the right direction.

@willviles
Copy link

@pichfl is right... the following deprecation warning is confusing. Help appreciated!

DEPRECATION: If you are overriding ember-router-scroll's implementation of "pushState", then you can subclass and override a new location object from: import HistoryLocation from '@ember/routing/history-location'; [deprecation id: ember-router-scroll]

export default HistoryLocation.extend({
pushState(path) {
deprecate(
`If you are overriding ember-router-scroll's implementation of "pushState", then you can subclass and override a new location object from: import HistoryLocation from '@ember/routing/history-location';`,
false,
{
id: 'ember-router-scroll',
until: '2.0.0'
}
);
const state = { path, uuid: uuid() };
get(this, 'history').pushState(state, null, path);
set(this, '_previousURL', this.getURL());
},
replaceState(path) {
deprecate(
`If you are overriding ember-router-scroll's implementation of "replaceState", then you can subclass and override a new location object from: import HistoryLocation from '@ember/routing/history-location';`,
false,
{
id: 'ember-router-scroll',
until: '2.0.0'
}
);
const state = { path, uuid: uuid() };
get(this, 'history').replaceState(state, null, path);
set(this, '_previousURL', this.getURL());
}
});

@snewcomer snewcomer merged commit 3c40526 into master Jul 24, 2019
@snewcomer snewcomer deleted the sn/1.2.0 branch July 24, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release new version with fixed Ember 3.9 deprecations
5 participants