Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #204

Merged
merged 4 commits into from
Jul 24, 2019
Merged

Release 1.2.0 #204

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fffcd16
1.2.0
snewcomer Jun 17, 2019
9dfd138
update README
snewcomer Jun 18, 2019
bb6f321
Merge branch 'master' into sn/1.2.0
snewcomer Jul 24, 2019
07d2f8f
Updates to pkg.json
snewcomer Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
ember-router-scroll
==============================================================================

[![Build Status](https://travis-ci.org/dollarshaveclub/ember-router-scroll.svg?branch=master)](https://travis-ci.org/dollarshaveclub/ember-router-scroll)
[![Greenkeeper badge](https://badges.greenkeeper.io/dollarshaveclub/ember-router-scroll.svg)](https://greenkeeper.io/)
[![Build Status](https://travis-ci.org/DockYard/ember-router-scroll.svg?branch=master)](https://travis-ci.org/DockYard/ember-router-scroll)

> Scroll to page top on transition, like a non-SPA website. An alternative scroll behavior for Ember applications.

Expand All @@ -24,7 +23,7 @@ Compatibility
* Ember CLI v2.13 or above


Installation
Installation
------------------------------------------------------------------------------

```
Expand Down Expand Up @@ -54,7 +53,7 @@ const Router = EmberRouter.extend(PageTrackerMixin, RouterScroll, {

Edit `config/environment.js` and change `locationType`.
Also add `historySupportMiddleware: true,` to get live-reload working in nested routes.
(See [Issue #21](https://github.com/dollarshaveclub/ember-router-scroll/issues/21))
(See [Issue #21](https://github.com/DockYard/ember-router-scroll/issues/21))

```javascript
locationType: 'router-scroll',
Expand Down Expand Up @@ -240,7 +239,7 @@ Note: if `preserveScrollPosition` is set to true on the service, it will overrid

**1.** Manage preserveScrollPosition via service

When you need to modify `preserveScrollPosition` on the service for a specific transition, you should always reset the value after the transition occurs, otherwise all future transitions will use the same `preserveScrollPosition` value.
When you need to modify `preserveScrollPosition` on the service for a specific transition, you should always reset the value after the transition occurs, otherwise all future transitions will use the same `preserveScrollPosition` value.

Example:

Expand Down Expand Up @@ -275,18 +274,6 @@ export default Component.extend({
* `ember test`
* `ember test --server`

## Automatic Updates

This repository uses [Greenkeeper](https://greenkeeper.io/) to manage dependencies.
Before doing manual updates to dependencies, please check if a Greenkeeper pull request for the update already exists.

Greenkeeper updates are updated and merged following the steps listed below.

* `git checkout <greenkeeper-pull-request>`
* `nvm i`
* `yarn`
* `yarn update`

License
------------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ember-router-scroll",
"version": "1.1.0",
"version": "1.2.0",
"description": "Scroll to top with preserved browser history scroll position",
"keywords": [
"ember-addon",
Expand Down