support updating rating curves over time #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with the tabulated rating curve. But the intention is to get rid of DataFrames, and use StructArrays. For tables from GeoPackage, these are copied to columntables (a NamedTuple) and then wrapped in a StructArray. For Arrow tables we can do the same, except the StructArray will be backed by memory mapped Arrow data.
|
Ah, yes, my load db has similar changes. And nice to see use of StructArrays. Did you benchmark or profile this? Lets meet Monday to go through my branch. |
evetion
reviewed
Apr 17, 2023
Co-authored-by: Maarten Pronk <[email protected]>
evetion
approved these changes
Apr 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #23.
@evetion I think 5b32ba5 might go nicely with your plans for validation. The idea is to roll this out for all tables.
The test model that I added looks like this, with 2 basins left and right, and in between two rating curves, one fixed in time and one dynamic.
The dynamic one is raised slightly twice:
Which affects the outflow over this node: