Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acccomodate different Ratingtable under different conditions (time or water system situation) #23

Closed
gijsber opened this issue Nov 21, 2022 · 2 comments
Assignees
Labels
control Rule based control of physical layer

Comments

@gijsber
Copy link
Contributor

gijsber commented Nov 21, 2022

After consultation with endusers on 28/2/20223, it is decided that we do not need more complex weir formulas.

what we do need is the ability to accommodate different Qh-relations under different conditions, e.g. time dependent (difference between summer and wintertime settings) or a (simulated /measured) condition in the water system

[ ] conceptual design
[ ] implementation
[ ] unit tests
[ ] input validation
[ ] updated example model
[ ] updated tutorial/example model building script

@gijsber gijsber added this to Ribasim Nov 21, 2022
@gijsber gijsber moved this to 🔲 Todo in Ribasim Nov 21, 2022
@gijsber gijsber added this to the Sprint 23.1 increment milestone Nov 28, 2022
@gijsber gijsber changed the title extend/add more weir-options acccomodate different Ratingtable under different conditions (time or water system situation) Mar 1, 2023
@gijsber
Copy link
Contributor Author

gijsber commented Mar 1, 2023

conceptual design to be done by end of March

@gijsber gijsber assigned visr and unassigned visr Mar 1, 2023
@gijsber gijsber added control Rule based control of physical layer and removed enhancement labels Mar 1, 2023
@gijsber gijsber added the concept label Apr 6, 2023
@gijsber gijsber assigned visr and Huite Apr 6, 2023
@visr visr moved this from 🔲 Todo to 🏗 In progress in Ribasim Apr 13, 2023
@visr
Copy link
Member

visr commented Apr 17, 2023

Closing this, since the time-based condition was implemented in #165, and for the conditional control there is also #13.

@visr visr closed this as completed Apr 17, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control Rule based control of physical layer
Projects
Archived in project
Development

No branches or pull requests

3 participants