Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate edge output #174

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Associate edge output #174

merged 2 commits into from
Apr 18, 2023

Conversation

Huite
Copy link
Contributor

@Huite Huite commented Apr 18, 2023

No description provided.

@Huite Huite requested a review from visr April 18, 2023 13:22
@visr
Copy link
Member

visr commented Apr 18, 2023

Picture from #165 now from QGIS:

image

@gijsber gijsber added the QGIS Ribasim QGIS plugin label Apr 18, 2023
@gijsber
Copy link
Contributor

gijsber commented Apr 18, 2023

Nice, the only thing I do not really understand is: why do we see 3 and 4 as legend for the flows. I understand the outflow of 3, but I actually expected to outflow of 2 (instead of a reference to 4)

@Huite
Copy link
Contributor Author

Huite commented Apr 18, 2023

Those are the edge_id's. Which is perhaps an argument for also showing the edge_id as a label? But maybe greyed out.

@gijsber
Copy link
Contributor

gijsber commented Apr 18, 2023

yes, edge_id as label in grey would probably help

@visr
Copy link
Member

visr commented Apr 18, 2023

The edge_ids were basically added to support this feature. Otherwise we use (from_node_id, to_node_id) everywhere. The nodes are already labeled. In the plot, is it possible to show (from_node_id, to_node_id) as a label?

@Huite Huite merged commit b16f5e7 into main Apr 18, 2023
@Huite Huite deleted the associate_edge_output branch April 18, 2023 14:43
@visr visr mentioned this pull request Apr 18, 2023
@gijsber gijsber added this to the Sprint 23.3 increment milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QGIS Ribasim QGIS plugin
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants