-
Notifications
You must be signed in to change notification settings - Fork 4
Github workflows to utilize building on docker engine #61
Comments
@DieHard073055: Thanks for opening an issue, it is currently awaiting triage. The triage/accepted label can be added by foundation members by writing /triage accepted in a comment. DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@DieHard073055: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this! You can add area labels by leaving a DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/area workflows |
/area workflow |
/area packages |
/assign @mambisi can you help with this |
@fuxingloh cd.yml on this https://github.com/DeFiCh/metachain/blob/c0820458c0bad868dd36a495045ca24460cc5873/.github/workflows/cd.yml |
The setup and build are done on the GitHub workflow host instance via:
with this build and run step: metachain/.github/workflows/release-docker.yml Lines 36 to 49 in cb6307d
the binary is then copied into a Docker Image via: metachain/.github/workflows/release-docker.yml Lines 51 to 54 in cb6307d
and Lines 5 to 6 in cb6307d
This issue was created to move the build process into Docker Engine with |
okay got it |
I'm not too familiar with Cargo build. Since for other languages, you need to build on the same OS/target to run on the same target arch/env. Or generally that's how it's done afaik I will defer to you to make this decision, it might not warrant or require it. If you think otherwise just drop a note here with the explanation, I will close this issue. |
<!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: > Experimental As per the title. This PR adds multi-stage Docker build for `./meta-node`. All docker images now utilize Docker to build. Fixes #61 Signed-off-by: Fuxing Loh <[email protected]> Co-authored-by: Diehard073055 <[email protected]>
What would you like to be added:
Builds should use docker
qemu
+buildx
.Building on docker engine will allow us to utilize qemu.
Why is this needed:
To make the builds as OS agnostic as possible.
Reference Conversation
The text was updated successfully, but these errors were encountered: