Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

chore(renovate): replace dependabot with renovate #43

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Aug 30, 2022

What this PR does / why we need it:

Renovate has more features than dependabot, including the most requested feature of grouping related dependencies into a single PR.

I will automatically track:

  • GitHub Actions
  • Docker Image
  • Docker Compose
  • NPM Packages
  • Cargo Crates

Check out this PR #44, you can see all the dependencies it tracks.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #43 (c082045) into main (11a4243) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #43   +/-   ##
=====================================
  Coverage   3.79%   3.79%           
=====================================
  Files         10      10           
  Lines       1711    1711           
=====================================
  Hits          65      65           
  Misses      1646    1646           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Docker image for defich/metachain is ready!

Built with commit 0985812

  • docker pull ghcr.io/defich/metachain:09858129f2776f969616b1863bc1349206daaf59
  • docker pull ghcr.io/defich/metachain:pr-43

@fuxingloh fuxingloh marked this pull request as ready for review August 30, 2022 19:38
@fuxingloh fuxingloh requested a review from surangap as a code owner August 30, 2022 19:38
@@ -19,10 +19,10 @@ jobs:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normally like to hardcode the version. But could you please let me know the rational of using latest here :) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True we should do it for builds.

Normally, CD is inconsequential with multi-platform with docker qemu + buildx. However, since we're not building on image layer and including the binary directly we're not benefiting from it.

  • I think what we need is for cd.yml to utilize building on docker engine so we can utilize docker qemu.
  • While for ci.yml our builds should run on multi-platform via a matrix targeting different versions.

@DieHard073055 can you open 2 separate issues for these 2 problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope i understood everything.
#61
#62

Copy link
Contributor

@DieHard073055 DieHard073055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. I am not very familiar with Github actions.
LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/workflow kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants