-
Notifications
You must be signed in to change notification settings - Fork 4
chore(renovate): replace dependabot with renovate #43
Conversation
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
=====================================
Coverage 3.79% 3.79%
=====================================
Files 10 10
Lines 1711 1711
=====================================
Hits 65 65
Misses 1646 1646 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Docker image for defich/metachain is ready! Built with commit 0985812
|
@@ -19,10 +19,10 @@ jobs: | |||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I normally like to hardcode the version. But could you please let me know the rational of using latest here :) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True we should do it for builds.
Normally, CD is inconsequential with multi-platform with docker qemu
+ buildx
. However, since we're not building on image layer and including the binary directly we're not benefiting from it.
- I think what we need is for
cd.yml
to utilize building on docker engine so we can utilize docker qemu. - While for
ci.yml
our builds should run on multi-platform via a matrix targeting different versions.
@DieHard073055 can you open 2 separate issues for these 2 problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment. I am not very familiar with Github actions.
LGTM!
What this PR does / why we need it:
Renovate has more features than dependabot, including the most requested feature of grouping related dependencies into a single PR.
I will automatically track:
Check out this PR #44, you can see all the dependencies it tracks.