chore(dockerfile): multi-stage meta-node docker build #163

fuxingloh · 2022-11-23T03:36:33Z

What this PR does / why we need it:

Experimental

As per the title. This PR adds multi-stage Docker build for ./meta-node. All docker images now utilize Docker to build.

Fixes #61

netlify · 2022-11-23T03:36:38Z

✅ Deploy Preview for metachain ready!

Name	Link
🔨 Latest commit	`705e4c9`
🔍 Latest deploy log	https://app.netlify.com/sites/metachain/deploys/637ddbf57348b600097998cd
😎 Deploy Preview	https://deploy-preview-163--metachain.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-11-23T03:40:40Z

Codecov Report

Base: 6.37% // Head: 6.37% // No change to project coverage 👍

Coverage data is based on head (705e4c9) compared to base (a12ecd6).
Patch has no changes to coverable lines.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #163   +/-   ##
=====================================
  Coverage   6.37%   6.37%           
=====================================
  Files         14      14           
  Lines       1803    1803           
  Branches       3       3           
=====================================
  Hits         115     115           
  Misses      1688    1688

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

DieHard073055 · 2022-11-23T05:41:13Z

Dockerfile

@@ -1,16 +1,33 @@
-FROM ubuntu:22.04
+FROM ubuntu:22.04 AS builder


@wafflespeanut suggested we should use 20.04 since the latest LTS version have compatibility issues.

Let's open another PR for that

We can also use debian-11? Can you open an issue for this.

Dockerfile

DieHard073055

Looks good! Thanks

fuxingloh · 2022-11-23T06:24:12Z

.github/workflows/release-docker.yml

+        with:
+          buildkitd-flags: --oci-worker-max-parallelism=1


@DieHard073055 without the max-parallelism=1 set, it will run concurrently with 4 images getting built at the same time, leading to out-of-memory (Code 137). We need to address this.

Dockerfile

fuxingloh · 2022-11-23T07:30:18Z

We could remove the platforms: first and create another separate issue to add back multi-platform builds.

Since the main/goal blocker isn't cross-compilation.

Dockerfile

Co-authored-by: Eshan Shafeeq <[email protected]> Signed-off-by: Fuxing Loh <[email protected]>

Dockerfile

Signed-off-by: Fuxing Loh <[email protected]>

.github/workflows/release-docker.yml

github-actions · 2022-11-23T09:10:39Z

Docker image for defich/metachain is ready!

Built with commit f1a9cfd

docker pull ghcr.io/defich/metachain:f1a9cfdc363bcc4c6c173eb61ca7ec0d3cee6dd8
docker pull ghcr.io/defich/metachain:pr-163

DieHard073055

Looks good to me.
Thanks for taking care of this. Its been blocking me.

fuxingloh had a problem deploying to Release Docker November 23, 2022 03:36 Failure

defichain-bot added area/workflow kind/chore Non feature change labels Nov 23, 2022

fuxingloh requested a review from DieHard073055 November 23, 2022 03:46

fuxingloh had a problem deploying to Release Docker November 23, 2022 03:59 Failure

fuxingloh had a problem deploying to Release Docker November 23, 2022 04:11 Failure

fuxingloh had a problem deploying to Release Docker November 23, 2022 05:04 Failure

fuxingloh added 2 commits November 23, 2022 13:29

chore(dockerfile): multistage meta-node docker build

15423ba

use debian:11-slim

7c6853f

fuxingloh force-pushed the fuxingloh/docker-builds branch from e73cb11 to 7c6853f Compare November 23, 2022 05:29

fuxingloh had a problem deploying to Release Docker November 23, 2022 05:29 Error

change back to ubuntu:22.04

a041c4c

DieHard073055 reviewed Nov 23, 2022

View reviewed changes

fuxingloh had a problem deploying to Release Docker November 23, 2022 05:43 Error

DieHard073055 reviewed Nov 23, 2022

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

DieHard073055 previously approved these changes Nov 23, 2022

View reviewed changes

add --oci-worker-max-parallelism=1

90d59c5

fuxingloh dismissed DieHard073055’s stale review via 90d59c5 November 23, 2022 05:47

fuxingloh had a problem deploying to Release Docker November 23, 2022 05:48 Failure

fuxingloh commented Nov 23, 2022

View reviewed changes

Dockerfile Show resolved Hide resolved

add max-parallelism to config file

7081894

DieHard073055 had a problem deploying to Release Docker November 23, 2022 07:09 Failure

add enable worker oci to config file

d3f4a9b

DieHard073055 had a problem deploying to Release Docker November 23, 2022 07:30 Failure

DieHard073055 reviewed Nov 23, 2022

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

Update Dockerfile

5073e4e

Co-authored-by: Eshan Shafeeq <[email protected]> Signed-off-by: Fuxing Loh <[email protected]>

fuxingloh had a problem deploying to Release Docker November 23, 2022 08:13 Failure

fuxingloh commented Nov 23, 2022

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

Update Dockerfile

01bbc5f

Signed-off-by: Fuxing Loh <[email protected]>

fuxingloh had a problem deploying to Release Docker November 23, 2022 08:14 Failure

fuxingloh mentioned this pull request Nov 23, 2022

docker caching is currently not supported due to limitations of cargo/issues/2644. However, there are ways around this. #164

Open

add --oci-worker-max-parallelism=1

d451c47

fuxingloh had a problem deploying to Release Docker November 23, 2022 08:35 Failure

fix Dockerfile

705e4c9

fuxingloh temporarily deployed to Release Docker November 23, 2022 08:38 Inactive

fuxingloh commented Nov 23, 2022

View reviewed changes

.github/workflows/release-docker.yml Show resolved Hide resolved

fuxingloh mentioned this pull request Nov 23, 2022

enable docker multi-platform build #165

Open

fuxingloh marked this pull request as ready for review November 23, 2022 09:25

fuxingloh requested review from canonbrother, DieHard073055 and wafflespeanut November 23, 2022 09:25

DieHard073055 approved these changes Nov 23, 2022 •

edited

Loading

View reviewed changes

DieHard073055 approved these changes Nov 23, 2022

View reviewed changes

canonbrother approved these changes Nov 23, 2022

View reviewed changes

fuxingloh merged commit 419304b into main Nov 23, 2022

fuxingloh deleted the fuxingloh/docker-builds branch November 23, 2022 10:38

fuxingloh mentioned this pull request Nov 23, 2022

Use debian-11 for metachain build docker base image #166

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(dockerfile): multi-stage meta-node docker build #163

chore(dockerfile): multi-stage meta-node docker build #163

fuxingloh commented Nov 23, 2022

netlify bot commented Nov 23, 2022 •

edited

Loading

codecov bot commented Nov 23, 2022 •

edited

Loading

DieHard073055 Nov 23, 2022

fuxingloh Nov 23, 2022

fuxingloh Nov 23, 2022

DieHard073055 Nov 23, 2022

DieHard073055 left a comment

fuxingloh Nov 23, 2022

fuxingloh commented Nov 23, 2022 •

edited

Loading

github-actions bot commented Nov 23, 2022

DieHard073055 left a comment

		@@ -1,16 +1,33 @@
		FROM ubuntu:22.04
		FROM ubuntu:22.04 AS builder

chore(dockerfile): multi-stage meta-node docker build #163

chore(dockerfile): multi-stage meta-node docker build #163

Conversation

fuxingloh commented Nov 23, 2022

What this PR does / why we need it:

netlify bot commented Nov 23, 2022 • edited Loading

✅ Deploy Preview for metachain ready!

codecov bot commented Nov 23, 2022 • edited Loading

Codecov Report

DieHard073055 Nov 23, 2022

Choose a reason for hiding this comment

fuxingloh Nov 23, 2022

Choose a reason for hiding this comment

fuxingloh Nov 23, 2022

Choose a reason for hiding this comment

DieHard073055 Nov 23, 2022

Choose a reason for hiding this comment

DieHard073055 left a comment

Choose a reason for hiding this comment

fuxingloh Nov 23, 2022

Choose a reason for hiding this comment

fuxingloh commented Nov 23, 2022 • edited Loading

github-actions bot commented Nov 23, 2022

DieHard073055 left a comment

Choose a reason for hiding this comment

netlify bot commented Nov 23, 2022 •

edited

Loading

codecov bot commented Nov 23, 2022 •

edited

Loading

fuxingloh commented Nov 23, 2022 •

edited

Loading