Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-3902] Add configuration for action name privacy control #199

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Apr 15, 2024

Context

RUM-3902 Add privacy control for action names

Change

Add enable_privacy_for_action_name in the configuration schema.

@cy-moi cy-moi marked this pull request as ready for review April 16, 2024 07:55
@cy-moi cy-moi requested review from a team as code owners April 16, 2024 07:55
N-Boutaib
N-Boutaib previously approved these changes Apr 16, 2024
"enabled_privacy_for_action_name": {
"type": "boolean",
"description": "Privacy control for action name",
"readOnly": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why readonly is being set to false in this case ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think this field is configurable and should not be read only.

@cy-moi cy-moi changed the title [RUM-3902] Add configuration for action name privacy control ✨ [RUM-3902] Add configuration for action name privacy control Apr 16, 2024
xgouchet
xgouchet previously approved these changes Apr 16, 2024
@cy-moi cy-moi dismissed stale reviews from xgouchet and N-Boutaib via 88f0b69 April 16, 2024 11:30
@cy-moi cy-moi requested review from xgouchet and N-Boutaib April 16, 2024 11:52
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cy-moi cy-moi merged commit 844e2f4 into master Apr 17, 2024
8 checks passed
@cy-moi cy-moi deleted the congyao/RUM-3902-privacy-control-action-name branch April 17, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants