Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-3902] Add configuration for action name privacy control #199

Merged
merged 3 commits into from
Apr 17, 2024
Merged

✨ [RUM-3902] Add configuration for action name privacy control #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3a5e5c
Add configuration for action name pivacy control
cy-moi Apr 15, 2024
8977956
Add build
cy-moi Apr 15, 2024
88f0b69
Fix typo
cy-moi Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/cjs/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
* Session replay default privacy level
*/
default_privacy_level?: string;
/**
* Privacy control for action name
*/
enable_privacy_for_action_name?: boolean;
/**
* Whether the request origins list to ignore when computing the page activity is used
*/
Expand Down
4 changes: 4 additions & 0 deletions lib/esm/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
* Session replay default privacy level
*/
default_privacy_level?: string;
/**
* Privacy control for action name
*/
enable_privacy_for_action_name?: boolean;
/**
* Whether the request origins list to ignore when computing the page activity is used
*/
Expand Down
1 change: 1 addition & 0 deletions samples/telemetry-events/configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"action_name_attribute": "foo",
"use_allowed_tracing_origins": false,
"default_privacy_level": "mask",
"enable_privacy_for_action_name": false,
"use_excluded_activity_urls": false,
"track_frustrations": true,
"track_views_manually": true,
Expand Down
5 changes: 5 additions & 0 deletions schemas/telemetry/configuration-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@
"description": "Session replay default privacy level",
"readOnly": false
},
"enable_privacy_for_action_name": {
"type": "boolean",
"description": "Privacy control for action name",
"readOnly": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Question: Why readonly is being set to false in this case ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think this field is configurable and should not be read only.

},
"use_excluded_activity_urls": {
"type": "boolean",
"description": "Whether the request origins list to ignore when computing the page activity is used"
Expand Down
Loading