-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-3902] Add privacy control for action names #2707
Conversation
packages/rum-core/src/domain/action/getActionNameFromElement.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/action/getActionNameFromElement.ts
Outdated
Show resolved
Hide resolved
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
==========================================
+ Coverage 93.60% 93.62% +0.02%
==========================================
Files 243 242 -1
Lines 7094 7108 +14
Branches 1580 1589 +9
==========================================
+ Hits 6640 6655 +15
+ Misses 454 453 -1 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
…n-name into staging-17 Co-authored-by: cy-moi <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
f5fd1a2
to
18eaec5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Commit 82036b1ee4 had already been merged into staging-21 If you need support, contact us on Slack #devflow! |
Co-authored-by: Aymeric <[email protected]>
Motivation
To be consistent with session Replay and ease the customer configuration, we could use the same privacy options as Replay. To avoid breaking changes, we need to add an extra init option that indicates the action names should take into account the defaultPrivacyLevel and the HTML overrides.
Desired behavior
When the user opt-in for
enablePrivacyForActionName
, we mask action names when no action name attributes given and no html override.When the user does not opt-in for this feature, we mask action names when html override is set.
Changes
Add an opt-in field
enablePrivacyForActionName: boolean
in configuration. OnceenablePrivacyForActionName: true
, the action name computation would behave (taking into account of all privacy configs) as follow:This also works for html override
data-dd-privacy
accordingly.Testing
I have gone over the contributing documentation.