-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-3902] Add privacy control for action names #2707
Merged
Merged
Changes from 8 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
a04be9d
Add enablePrivacyForActionName in config; implement action name mask …
cy-moi 4406479
Fix import from browser-rum-core
cy-moi 1357c7e
Add enable_privacy_for_action_name into configuration
cy-moi 42fc259
Sync types with rum-events-format
cy-moi e6d225c
🐛 Fix bugs found in comments
cy-moi 78a5adf
Fix hidden unit test
cy-moi f4e1a28
Fix getActionName return type
cy-moi f0dacd9
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi be8341e
Move privacy check earlier
cy-moi 6d79c86
Remove unnecessary check for clickActionBase
cy-moi e2d2c24
Add html attribute overide in fallback strategies
cy-moi 31ee24b
Make lint happy
cy-moi 18eaec5
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi 55a4767
Handle IE non polyfilled svg element classlist
cy-moi c7de5b2
Use polyfills for handling classlist contains
cy-moi 1114a44
Fix polyfill
cy-moi 520e573
Fix bug
cy-moi 6f92895
Simplify logic and fix for comments
cy-moi 5773809
Make config param requried for getActionName
cy-moi 62e821f
Simplify click base privacy logic
cy-moi 9a054d1
Add Todo comment; Merge constants into privacy
cy-moi 82036b1
Add check experimental feature flag in configuration
cy-moi e4c5a6d
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi 4c2b100
Masked should be false when there is custom name
cy-moi 0453e4f
Remove log
cy-moi 24f18ac
Remove additional field according to new updates
cy-moi 38f7791
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi 759ccb8
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi 699d199
Add function getPrivacySelector and replace polyfills
cy-moi 93789ac
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi 897ab13
Remove unused import
cy-moi 00e8f09
Explicit pointerdown when emulate click
cy-moi b6b1df0
Fix unit test for IE
cy-moi b1fda28
Add test coverage for configuration
cy-moi c3458bc
Update packages/rum-core/src/domain/configuration.ts
cy-moi 8c66817
Remove masked param from interface
cy-moi 0582b8a
Fix typo
cy-moi 5218ca7
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi 49ca7ea
Merge branch 'main' into congyao/RUM-3902-privacy-control-action-name
cy-moi ab4261c
Fix typo
cy-moi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: The file name "constants.ts" is too generic. All constants in that file are related to privacy. Maybe it could merged into the "privacy.ts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I merged it in
privacy.ts
.