🔊 [RUM-253] customize deflate worker failure logs #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
This was referenced Sep 5, 2023
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
bcaudan
approved these changes
Sep 6, 2023
| @@ -126,6 +126,7 @@ export function makeRecorderApi( | |||
|
|
|||
| const worker = startDeflateWorker( | |||
| configuration, | |||
| 'Datadog Session Replay', | |||
There was a problem hiding this comment.
❓ question: any specific intent by adding "Datadog" prefix to the message?
There was a problem hiding this comment.
I wanted to use Datadog RUM for the RUM Browser SDK, so to mimic this pattern I thought Datadog Session Replay could be nice. I've seen multiple customers using different Session Replay and RUM solution at the same time, so mentioning Datadog could help a bit.
There was a problem hiding this comment.
It may worth adding the Datadog prefix for all our messages then.
There was a problem hiding this comment.
I'll do that in a separate PR
amortemousque
approved these changes
Sep 7, 2023
BenoitZugmeyer
force-pushed
the
benoit/compress--add-deflate-worker-source
branch
from
e6fc07b to
4fa98c7
Compare
BenoitZugmeyer
deleted the
benoit/compress--add-deflate-worker-source
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the coming PR, we'll want to start the deflate worker from different places (according to a
experimental flag/configuration option). The current error message mentioning "Session Replay" is
not adequate anymore.
Changes
This PR add the ability to adjust the error message.
Testing
I have gone over the contributing documentation.